Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

advertise updated addresses via mDNS #1163

Open
marten-seemann opened this issue Aug 18, 2021 · 2 comments · May be fixed by #3096
Open

advertise updated addresses via mDNS #1163

marten-seemann opened this issue Aug 18, 2021 · 2 comments · May be fixed by #3096
Labels
effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up

Comments

@marten-seemann
Copy link
Contributor

At the moment we're just advertising a static set of addresses. Instead, we should be listening to "address change" events.
@marten-seemann marten-seemann mentioned this issue Aug 18, 2021
Merged
@Stebalien Stebalien added effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up labels Aug 24, 2021
@schomatis schomatis mentioned this issue Jun 22, 2022
Closed
3 tasks
@marten-seemann marten-seemann added help wanted Seeking public contribution on this issue good first issue Good issue for new contributors labels Feb 7, 2023
@MarcoPolo
Copy link
Collaborator

We should use the eventbus to get notified about address change events.

@MarcoPolo MarcoPolo added the exp/expert Having worked on the specific codebase is important label Jun 19, 2023
@MOHANKUMAR-IT MOHANKUMAR-IT linked a pull request Dec 9, 2024 that will close this issue
Open
@MOHANKUMAR-IT
Copy link

MOHANKUMAR-IT commented Dec 12, 2024 •
edited
Loading

Have raised pull request for the fix guys.
Is there any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix : Announcing static addresses for mDNS MOHANKUMAR-IT/go-libp2p
4 participants
@Stebalien @MarcoPolo @marten-seemann @MOHANKUMAR-IT