Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Ed25519 Private Key length #200

Open
TJKoury opened this issue Oct 7, 2021 · 1 comment · May be fixed by #269
Open

Ed25519 Private Key length #200

TJKoury opened this issue Oct 7, 2021 · 1 comment · May be fixed by #269
Assignees
@mpetrunic
Labels
good first issue Good issue for new contributors help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@TJKoury
Copy link

TJKoury commented Oct 7, 2021

Constructing a new Ed25519 key by passing a 32 byte Uint8Array should be allowed. I assume this check is due to the convention of passing in private & public concatenated, would be nice to detect a 32 byte key per the spec.

I could work on a pull if this is of interest to anyone else.

js-libp2p-crypto/src/keys/ed25519-class.js

Line 44 in a99f419

// key - 64 byte Uint8Array containing private key

@BigLep BigLep added the need/triage Needs initial labeling and prioritization label Oct 15, 2021
@mpetrunic
Copy link
Member

@TJKoury You are right, this makes no sense. We would love if you could open PR!

@mpetrunic mpetrunic added need/author-input Needs input from the original author and removed need/triage Needs initial labeling and prioritization labels Jun 3, 2022
@mpetrunic mpetrunic added help wanted Seeking public contribution on this issue status/ready Ready to be worked good first issue Good issue for new contributors and removed need/author-input Needs input from the original author labels Jun 14, 2022
@mpetrunic mpetrunic linked a pull request Aug 1, 2022 that will close this issue
Open
@BigLep BigLep added the P2 Medium: Good to have, but can wait until someone steps up label Sep 6, 2022
@tinytb tinytb moved this to In Review in js-libp2p Oct 11, 2022
@tinytb tinytb added this to js-libp2p Oct 11, 2022
@mpetrunic mpetrunic self-assigned this Dec 5, 2022
@p-shahi p-shahi removed this from js-libp2p Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mpetrunic mpetrunic

Labels
good first issue Good issue for new contributors help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow ed25519 to be instantiated with non concatenated key libp2p/js-libp2p-crypto
3 participants
@BigLep @TJKoury @mpetrunic