Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add matchesPrivateKey and matchesPublicKey #23

Open
dignifiedquire opened this issue May 21, 2016 · 3 comments
Open

Add matchesPrivateKey and matchesPublicKey #23

dignifiedquire opened this issue May 21, 2016 · 3 comments
Labels
help wanted Seeking public contribution on this issue status/ready Ready to be worked

Comments

@dignifiedquire
Copy link
Member

These are needed in js-libp2p-secio. Reference implementation in go: https://github.com/ipfs/go-libp2p-peer/blob/master/peer.go#L55-L67
@daviddias
Copy link
Member

👍

@daviddias
Copy link
Member

@dignifiedquire can you add these methods? Right now secio is not doing this verification, right?

@dignifiedquire
Copy link
Member Author

Yes currently we are not doing this verification, as these methods are missing.

@dignifiedquire dignifiedquire added the help wanted Seeking public contribution on this issue label Nov 7, 2016
@dignifiedquire dignifiedquire removed their assignment Nov 7, 2016
@daviddias daviddias added the status/ready Ready to be worked label Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Seeking public contribution on this issue status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dignifiedquire @daviddias