Replies: 2 comments
-
Current Test Coverage@seetadev Thank you for the detailed testing suggestions! Here's an overview of what test scenarios are already implemented in the current rendezvous PR and what could be added for even better coverage. ✅ Multiple namespaces (peer1 in /chat, peer2 in /files)
✅ Expired registrations (TTL handling)
✅ No peers registered → query should return empty
The core scenarios are covered, but large-scale testing (100+ peers) could be enhanced. |
Beta Was this translation helpful? Give feedback.
-
@sumanjeet0012 : Great, thank you so much for sharing. Appreciate it. We will try and get server access to conduct tests at scale. Will update you as soon as I hear back from friends & collaborators. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Hi @sumanjeet0012,
I spent some time digging deeper into where the Rendezvous peer discovery module fits best, and I wanted to share some notes + recommendations before we finalize the PR.
When is Rendezvous Discovery Useful?
Rendezvous peer discovery shines in scenarios where:
/chat/v1
,/file-share/test
).In practice, peers:
This is extremely useful in application-level overlays (chat, collaborative tools, service directories) where direct peer bootstrapping is hard to manage.
Suggested Test Case to Add
To ensure correctness and interoperability, I recommend adding at least one end-to-end test that covers the following flow:
peer1
,peer2
).peer1
registers under a namespace (say"test-namespace"
).peer2
queries the rendezvous server for the same namespace.peer2
receivespeer1
in the discovery results.Pseudo-code outline (Python-style):
This test ensures that the module works as expected and gives us confidence before merging.
Possible Extensions (for later)
Once the base test is in place, we could also explore:
peer1
in/chat
,peer2
in/files
)Next Step
We are very close to merging this PR 🎉.
Would you be able to add a basic registration + discovery test case before we finalize?
This will:
Thanks again for the great work pushing this forward.
CCing @pacrob in this discussion thread. Thank you Paul for your continued guidance and support.
Beta Was this translation helpful? Give feedback.
All reactions