Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

Make sure proper values are passed for metrics #69

Open
aemadrid opened this issue Apr 29, 2013 · 1 comment
Open

Make sure proper values are passed for metrics #69

aemadrid opened this issue Apr 29, 2013 · 1 comment

Comments

@aemadrid
Copy link

Because of an error in my code I ended up passing a bad hash as a value:

data = { :type => :counter, :value => { :value => 35 } }
Librato::Metrics.submit :my_metric => data

That resulted in sending this:

{
    "gauges": [
        {
            "name": "my_metric",
            "source": null,
            "value": {
                "value": 35
            }
        }
    ]
}

It would be great if the library recognized my error before sending it.

@nextmat
Copy link
Contributor

nextmat commented Apr 30, 2013

Adrian,

Thanks for the feedback. We'll consider adding this in a future release!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants