Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDR Capable device cannot see hdr streams in the quality meter #6262

Closed
3 tasks done
alejandro-alzate opened this issue Jul 20, 2024 · 2 comments
Closed
3 tasks done
Labels
bug Something isn't working

Comments

@alejandro-alzate
Copy link

alejandro-alzate commented Jul 20, 2024

Steps to reproduce

press options
select quality
select best quality

Expected behavior

720/1080/1440/2160HDR options should be listed

Actual behavior

hdr never is listed

LibreTube version

0.24.0

Android version

LineageOS 20 (Android 13)

Other details

#4195 and #5147 mentions that when compatible it will enable it, now my phone has an oled panel and for other things like vlc the osk and the aod can successfully show true black while libretube shows gray bars and the black on videos that are hdr never get true darkness.

If this on my side at least it would be cool to have some "shader" overlayed on the video that makes tone mapping to the capabilities of my screen.

Also i noticed the official YT App flickers when the video is being moved while it trasitions from normal, fullscreen, and pip it goes from hdr to sdr then back hdr during it.

But libretube only messes with the brightness, I don't know if that fact matters but at least is worth the mention.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@alejandro-alzate alejandro-alzate added the bug Something isn't working label Jul 20, 2024
@Bnyro
Copy link
Member

Bnyro commented Aug 10, 2024

HDR is only working via DASH, which is broken as of now: #5855

@Bnyro Bnyro closed this as not planned Won't fix, can't repro, duplicate, stale Aug 10, 2024
@alejandro-alzate
Copy link
Author

alejandro-alzate commented Aug 10, 2024

That sucks but alright i'll wait
DO NOT FEEL RUSHED bc im losing like 5% of battery by not having hdr though.

Edit: nvm i just checked and is not even your fault, it is broken from newpipe...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants