Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist menu is basically dead #6306

Closed
3 tasks done
alejandro-alzate opened this issue Jul 29, 2024 · 8 comments · Fixed by #6588
Closed
3 tasks done

Playlist menu is basically dead #6306

alejandro-alzate opened this issue Jul 29, 2024 · 8 comments · Fixed by #6588
Labels
bug Something isn't working can't reproduce

Comments

@alejandro-alzate
Copy link

alejandro-alzate commented Jul 29, 2024

Steps to reproduce

  1. pick a video
  2. disable the auto-play button
  3. open playlist selector (between) sponsor block and settings
  4. click any video

Expected behavior

Video should change to selected video

Actual behavior

Video in playlist gets highlighted then nothing happens

LibreTube version

0.24.0 - Initial version
0.25.2 - Current version with the bug as editing this

Android version

LineageOS 20 (android 13)

Other details

Demo video 0.24.0: https://www.youtube.com/watch?v=lKt68uPxehU
Demo video 0.25.2: https://www.youtube.com/watch?v=qAdS_ftzfOQ
Auto-play fix discovery: https://www.youtube.com/watch?v=g84bLMcEdgA

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@alejandro-alzate alejandro-alzate added the bug Something isn't working label Jul 29, 2024
@alejandro-alzate
Copy link
Author

I noticed that the issue was tagged can't reproduce
so here i attach a video showcasing it: https://www.youtube.com/watch?v=qAdS_ftzfOQ

@alejandro-alzate
Copy link
Author

alejandro-alzate commented Sep 29, 2024

I just noticed that turning on the auto play feature fixes it which is weird.
https://www.youtube.com/watch?v=g84bLMcEdgA
Also you may also noticed the multiple libretube instances, Android was killing constantly (Low ram), and I rebooted to get usb debugging working.

My lousy 4GB phone can't cope with android 13:
Screenshot_20240929-084337_Termux

@alejandro-alzate
Copy link
Author

Hello @Bnyro I was curious if I can get the latest apk with this fix applied.
Seems that the github action is still stuck on 0.25.2

You can use me as cannon meat on the way there. y'know making you aware of any new bugs popping up and such.

@akano12
Copy link
Collaborator

akano12 commented Oct 18, 2024

@alejandro-alzate
Copy link
Author

understood, g'night sir.
I'm installing it now.
I'll let you know if I find funny bussiness.

@alejandro-alzate
Copy link
Author

wh- huh it says that is 0.25.2 (57)
Also on install it did not kill the pip.

@akano12
Copy link
Collaborator

akano12 commented Oct 18, 2024

wh- huh it says that is 0.25.2 (57)
Also on install it did not kill the pip.

It's a debug build, separate application that contains bug fixes and features that aren't released in stable builds yet

@alejandro-alzate
Copy link
Author

Understood, just got a bit thrown off.
Also thoughtful touch giving them a different icon hue, otherwise I wouldn't be able to tell them apart.

But as of writing of this, the fix is functional and have not seen any other bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working can't reproduce
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants