Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHP docs to be consistent about rendered filename #19

Open
jonyo opened this issue May 19, 2015 · 1 comment
Open

Update PHP docs to be consistent about rendered filename #19

jonyo opened this issue May 19, 2015 · 1 comment

Comments

@jonyo
Copy link
Member

jonyo commented May 19, 2015

The "real" spec for a render, says it should not change the current fileType to match the rendered image file type, it should just return the filename when the render() method is called. If, as part of the render process, it uses a conversion (like OpenSCAD to STL), that is OK to change the file type. But the file type should always be for the current non-rendered 3d file.

This spec was developed over time, and some of the PHP docs for some methods state that the fileType could match the "converted" or the "rendered" file type, update all places in the code to reflect the latest spec (fileType only changes for converters).

@jonyo jonyo added this to the 1.2.1 milestone May 19, 2015
@jonyo jonyo modified the milestones: 1.2.2, 1.2.1 Jun 17, 2017
@jonyo
Copy link
Member Author

jonyo commented Feb 5, 2019

Note: this repo hasn't had much change but we are still around! We just haven't had much need for change.

If anyone wants to help contribute this is a good issue to start with. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant