Shared-state mesh information packages async implmentation and reference state #1112

javierbrk · 2024-05-13T14:38:14Z

No description provided.

G10h4ck

See inline comments.
Also please double check reference state data folder is persisted across firmware ugrades. The behaviour should be that it get lost if sysupgrade -n is used while it should be kept if plain sysupgrade is used. AFAIR file or folders that need to be kept accross upgrades need to be added in a list somewhere. Same goes for safe-upgrade.

G10h4ck · 2024-06-20T08:28:37Z

packages/shared-state-babel_links_info/files/etc/uci-defaults/shared-state_babel_links_info

 uci set shared-state.babel_links_info=dataType
 uci set shared-state.babel_links_info.name='babel_links_info'
 uci set shared-state.babel_links_info.scope='community'
 uci set shared-state.babel_links_info.ttl='2400'
 uci set shared-state.babel_links_info.update_interval='30'
 uci commit shared-state

+## Refference state data type


sobra una f ;-)

G10h4ck · 2024-06-20T08:30:55Z

packages/shared-state-babel_links_info/files/etc/shared-state/ref_state/babel_links_info_ref

@@ -0,0 +1 @@
+""


Is this an empty JSON file by default? In that case is more traditional to use an empty object {} instead of an empty string ;-) also we could use .json extension to make things more explicit, if it doesn't make things much more complex

Yes ! that was the first attempt, but when jsonc parses the text and then transforms it back to text, it creates an empty array, not an empty json object. For me it can be a bug. ..

JSON = require("luci.jsonc") print(JSON.stringify(JSON.parse("{}"))) []

the documentation states that "Lua tables are converted into JSON arrays if they only contain integer keys, mixed tables are turned into JSON objects with any existing numeric keys converted into strings."

G10h4ck · 2024-06-20T08:32:17Z

packages/shared-state-bat_links_info/files/etc/shared-state/ref_state/bat_links_info_ref

@@ -0,0 +1 @@
+""


same comment as packages/shared-state-babel_links_info/files/etc/shared-state/ref_state/babel_links_info_ref

G10h4ck · 2024-06-20T08:32:31Z

packages/shared-state-bat_links_info/files/etc/uci-defaults/shared-state_bat_links_info_cron

 uci set shared-state.bat_links_info=dataType
 uci set shared-state.bat_links_info.name='bat_links_info'
 uci set shared-state.bat_links_info.scope='community'
 uci set shared-state.bat_links_info.ttl='2400'
 uci set shared-state.bat_links_info.update_interval='30'
 uci commit shared-state
+
+## Refference state data type


sobra una f aqui tambien ;-)

G10h4ck · 2024-06-20T08:33:51Z

packages/shared-state-node_info/files/etc/shared-state/ref_state/node_info_ref

@@ -0,0 +1 @@
+""


Same comment as packages/shared-state-babel_links_info/files/etc/shared-state/ref_state/babel_links_info_ref

G10h4ck · 2024-06-20T08:34:11Z

packages/shared-state-node_info/files/etc/uci-defaults/shared-state_node_info_cron

+uci set shared-state.node_info_ref.name='node_info_ref'
+uci set shared-state.node_info_ref.scope='community'
+uci set shared-state.node_info_ref.ttl='2400'
+uci set shared-state.node_info_ref.update_interval='50'


Please add a new line at the end of the file

G10h4ck · 2024-06-20T08:34:21Z

packages/shared-state-node_info/files/etc/uci-defaults/shared-state_node_info_cron

+uci set shared-state.node_info.update_interval='33'
+uci commit shared-state
+
+## Refference state data type


sobra una f ;-)

G10h4ck · 2024-06-20T08:37:52Z

packages/shared-state-wifi_links_info/files/etc/shared-state/ref_state/wifi_links_info_ref

@@ -0,0 +1 @@
+""


Same comment as packages/shared-state-babel_links_info/files/etc/shared-state/ref_state/babel_links_info_ref

G10h4ck · 2024-06-20T08:38:06Z

packages/shared-state-wifi_links_info/files/etc/uci-defaults/shared-state_wifi_links_info

+uci set shared-state.wifi_links_info_ref.name='wifi_links_info_ref'
+uci set shared-state.wifi_links_info_ref.scope='community'
+uci set shared-state.wifi_links_info_ref.ttl='2400'
+uci set shared-state.wifi_links_info_ref.update_interval='50'


new line missing

javierbrk · 2024-06-27T14:03:58Z

See inline comments. Also please double check reference state data folder is persisted across firmware ugrades. The behaviour should be that it get lost if sysupgrade -n is used while it should be kept if plain sysupgrade is used. AFAIR file or folders that need to be kept accross upgrades need to be added in a list somewhere. Same goes for safe-upgrade.

yesss ! the reference state is not kept across upgrades.

G10h4ck

See inline comments

G10h4ck · 2024-08-01T08:22:30Z

packages/shared-state-bat_links_info/files/etc/uci-defaults/shared-state_bat_links_info_cron

@@ -4,10 +4,17 @@ unique_append()
 {
 	grep -qF "$1" "$2" || echo "$1" >> "$2"
 }
-
+## information generator datatype
 uci set shared-state.bat_links_info=dataType
 uci set shared-state.bat_links_info.name='bat_links_info'
 uci set shared-state.bat_links_info.scope='community'
 uci set shared-state.bat_links_info.ttl='2400'
 uci set shared-state.bat_links_info.update_interval='30'
 uci commit shared-state


This line needs to be moved after the last uci set at line 20 otherwise reference state configurations are not guaranteed to be persisted across reboot

G10h4ck · 2024-08-01T08:24:06Z

packages/shared-state-node_info/files/etc/uci-defaults/shared-state_node_info_cron

+uci set shared-state.node_info_ref.name='node_info_ref'
+uci set shared-state.node_info_ref.scope='community'
+uci set shared-state.node_info_ref.ttl='2400'
+uci set shared-state.node_info_ref.update_interval='50'


uci commit shared-state must be moved here

G10h4ck · 2024-08-01T08:25:47Z

packages/shared-state-ref_state_commons/README.md

+
+Reference state is designed to contain information about the node that will
+persist and that is not changed to often. This is because it is stored in the
+device memory and to many consequent write operations may damage the memory. 


sed 's/memory/persistent memory/g'

G10h4ck · 2024-08-01T08:26:14Z

packages/shared-state-ref_state_commons/README.md

+persist and that is not changed to often. This is because it is stored in the
+device memory and to many consequent write operations may damage the memory. 
+
+One thing that is important to note is that no node stores the hole status of


G10h4ck · 2024-08-01T08:31:38Z

...tate-ref_state_commons/files/usr/share/shared-state/publishers/shared-state-publish_refstate

+#!/usr/bin/lua
+
+--! LibreMesh
+--! Will publish all refference data_type at once


refference/reference

packages/shared-state-wifi_links_info/files/etc/uci-defaults/shared-state_wifi_links_info

G10h4ck

See inline comments

G10h4ck · 2024-08-12T14:22:09Z

packages/shared-state-node_info/files/etc/uci-defaults/shared-state_node_info_cron

@@ -1,9 +1,21 @@
 #!/bin/sh
+
 unique_append()


This function is not used anymore should be removed, also the script should be renamed ;)

G10h4ck · 2024-08-12T14:22:36Z

packages/shared-state-babel_links_info/files/etc/uci-defaults/shared-state_babel_links_info

@@ -4,11 +4,17 @@ unique_append()
 	grep -qF "$1" "$2" || echo "$1" >> "$2"
 }


This function is not used anymore should be removed ;)

G10h4ck · 2024-08-12T14:23:02Z

packages/shared-state-bat_links_info/files/etc/uci-defaults/shared-state_bat_links_info_cron

@@ -4,10 +4,18 @@ unique_append()
 {
 	grep -qF "$1" "$2" || echo "$1" >> "$2"
 }


This function is not used anymore should be removed, also the script should be renamed ;)

G10h4ck · 2024-08-12T14:24:04Z

packages/shared-state-ref_state_commons/files/etc/uci-defaults/90-shared-state-ref-persistence

+uci set lime-defaults.system.keep_on_upgrade="$(uci get lime-defaults.system.keep_on_upgrade) shared-state-ref-state"
+uci commit lime-defaults
+touch /tmp/done
+exit 0


missing line at the end of the file

G10h4ck · 2024-08-12T14:24:56Z

packages/shared-state-wifi_links_info/files/etc/uci-defaults/shared-state_wifi_links_info

@@ -1,9 +1,21 @@
 #!/bin/sh
+
 unique_append()


This function is not used anymore should be removed ;)

javierajorge and others added 24 commits April 15, 2024 22:58

shared-state: moving to async

97c6e58

Merge branch 'libremesh:master' into moving_to_async

9221be5

shared-state-async: Removes cron task

5a36c2c

shared-state-async: move publishers to new location

9ab43ff

shared_satate_bat_links: addss new key pair structure

6d1d112

adds hook to insert config

8cceccc

fixes typo

1f72404

bat_links_info_ref: adds data type registration

ccfd634

ref_state: add babel and missing bat links reference state

b53b37d

ref_state: adds key index to links

e686037

Merge branch 'libremesh:master' into moving_to_async

825e1a5

shared-state: fiexes broken tests

331e5f0

shared-state: adds wifi key to info data type

4f5c936

ref_state: implements commons package

f9054bc

Merge branch 'moving_to_async' into f/reference_state

2495b39

ref_state: implement publishser

991fa73

ref_state: improve doc

f4d2124

ref_state: fiexes print and nodeinfo ref datatype

bea395b

removes reference data type old sync method

49adce0

Merge branch 'libremesh:master' into f/reference_state

bf3dfbb

ref_state: adds insert rpc call

6ce5f04

ref_state: removes rpcd publish

8c2a7de

ref_state: fixes bug in wifi interface

9c5e287

ref_state: fixes sync with ips

af48dd6

javierbrk mentioned this pull request May 13, 2024

Move mesh wide status packages to shared-state-async #1107

Closed

javierajorge added 5 commits May 13, 2024 11:53

updates packages and publisher

098de02

ref_state: renaming

f6d4f11

ref_state: fixes typo

8cd9ec5

fixes more typos

c9084b9

ref_state:fixes publication strings error

c14ce5e

javierajorge and others added 3 commits May 28, 2024 18:20

ref_state: fix test for write_if_diff

b95fed2

change default reference state

3f55caf

Merge branch 'libremesh:master' into f/reference_state

8034373

G10h4ck added this to the mesh-wide milestone Jun 20, 2024

G10h4ck changed the title ~~Shared-state mesh information pacakeges async implmentation and refference state~~ Shared-state mesh information packages async implmentation and reference state Jun 20, 2024

G10h4ck requested changes Jun 20, 2024

View reviewed changes

javierbrk marked this pull request as ready for review June 25, 2024 19:49

javierajorge and others added 6 commits June 27, 2024 11:35

ref_state: add missing new line at end of files and removes extra f

5312ac4

ref_state: adds wifi links location

02bdc7f

ref_state: fixes location issue

a9224f9

Ref_state: removes unnecessary locations

bb44561

ref_state: new generic location implementation

1eca555

ref_state: new generic location for bat links and babel links

0e45a85

G10h4ck requested changes Aug 1, 2024

View reviewed changes

javierbrk added 3 commits August 1, 2024 16:00

f_ref_state: add commit at the end of the uci defaults files

f06d125

ref_state: fix typos

e85670d

Merge branch 'master' into f/reference_state

b19b1ca

javierbrk force-pushed the f/reference_state branch from fc5370e to b19b1ca Compare August 9, 2024 13:02

javierbrk added 4 commits August 9, 2024 10:04

ref_state: implements persistence

f46ea9a

ref_state: fix script dir

cf4c38e

ref_state: fixes lime default usage

660b0ce

ref_state: fixes early call to publish error in bat_links

c27def8

G10h4ck requested changes Aug 12, 2024

View reviewed changes

javierbrk added 2 commits August 15, 2024 13:17

ref_state: clean up unused functions

e27ba12

ref_state: add new line at the end of file

8791409

G10h4ck approved these changes Aug 28, 2024

View reviewed changes

G10h4ck merged commit 527c1eb into libremesh:master Aug 28, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shared-state mesh information packages async implmentation and reference state #1112

Shared-state mesh information packages async implmentation and reference state #1112

javierbrk commented May 13, 2024

G10h4ck left a comment

G10h4ck Jun 20, 2024

G10h4ck Jun 20, 2024

javierbrk Jun 27, 2024

G10h4ck Jun 20, 2024

G10h4ck Jun 20, 2024

G10h4ck Jun 20, 2024

G10h4ck Jun 20, 2024

G10h4ck Jun 20, 2024

G10h4ck Jun 20, 2024

G10h4ck Jun 20, 2024

javierbrk commented Jun 27, 2024

G10h4ck left a comment

G10h4ck Aug 1, 2024

G10h4ck Aug 1, 2024

G10h4ck Aug 1, 2024

G10h4ck Aug 1, 2024

G10h4ck Aug 1, 2024

G10h4ck left a comment

G10h4ck Aug 12, 2024

G10h4ck Aug 12, 2024

G10h4ck Aug 12, 2024

G10h4ck Aug 12, 2024

G10h4ck Aug 12, 2024

		@@ -4,11 +4,17 @@ unique_append()
		grep -qF "$1" "$2" \|\| echo "$1" >> "$2"
		}

Shared-state mesh information packages async implmentation and reference state #1112

Shared-state mesh information packages async implmentation and reference state #1112

Conversation

javierbrk commented May 13, 2024

G10h4ck left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

javierbrk commented Jun 27, 2024

G10h4ck left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

G10h4ck left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment