This repository has been archived by the owner on Aug 2, 2020. It is now read-only.
WIP: Lime-App integration #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncing, and changed name to note
nicopace
suggested changes
Jan 2, 2020
| end | ||
|
|
||
| local function add_member_voucher(msg) | ||
| local hostnameOutput = shell("cat /proc/sys/kernel/hostname") |
There was a problem hiding this comment.
looks unnecesary long... could be splitted in smaller functions that contain part of the functionalty? looks it has many responsabilities
spiccinini
suggested changes
Jan 2, 2020
|
Please merge this, for all that is most sacred pirania is very important for community networks to maintain and have a minimum of security in their virtual environments. |
Everyone wants this to be merged, but it still needs some work to get healthy enough to be part of the trunk. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 🚧 🚧