Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please redesign the docker container #663

Open
psych0d0g opened this issue Sep 18, 2024 · 1 comment
Open

Please redesign the docker container #663

psych0d0g opened this issue Sep 18, 2024 · 1 comment

Comments

@psych0d0g
Copy link

psych0d0g commented Sep 18, 2024

Description

I would like to run librespeed in a more secure environment, namely without the container requiring root permissions, and with a read-only rootfs where optimally only a tmp directory is mounted as a writeable volume for the upload test files and similar temporarily needed files

Why it should be implemented

Securitywise it is really bad to run this container as root, and the main apache process inside of it aswell, then let apache drop privileges and run the main app inside of it as a user (this is not a VM)
Please conside running it rootless and dont try to chmod stuff in this case.

Securitywise it also is best practice to not have the whole rootfs writeable

both in combination is just bad alltogether, especially when data from the client is used for the upload tests, one security vulnerability related to the upload speed test will open all the gates to remote shells and other bad actors.

@sstidl
Copy link
Collaborator

sstidl commented Sep 20, 2024

Hello, you seem to know what to do. Please submit a pull request for your changes. You know this is open source, any help is appreciated and welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants