Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DealerClient ignores pending messages sometimes #834

Open
notalexa opened this issue Jan 29, 2024 · 0 comments
Open

DealerClient ignores pending messages sometimes #834

notalexa opened this issue Jan 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@notalexa
Copy link

Describe the bug
The DealerClient ignores pending messages in the following situation (since two listeners are registered): The client receives a message for the second listener (pending). The first listener registers and starts processing. The message is ignored since the second listener is not registered yet.

To Reproduce
The situation was seen in the following situation (in most cases on a raspberry pi): Run the player with zeroconf. Select the player in the smartphone app. Sometimes, the player doesn't start playing and the app is waiting "forever" to display the player (because the transfer message is dropped in the player).

Expected behavior
The player should always start playing the current track

Screenshots/Stracktraces/Logs
No screenshot

Version/Commit
A fix is to start handling messages after the initialization is complete. An implementation can be found at https://github.com/notalexa/librespot-java/tree/timing-fixes (together with an additional finite socket timeout). (I hope, I found all occurences of starting the player.)

@notalexa notalexa added the bug Something isn't working label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant