Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additionnal SpotifyUri types #1266

Open
acolombier opened this issue Mar 19, 2024 · 2 comments
Open

Support additionnal SpotifyUri types #1266

acolombier opened this issue Mar 19, 2024 · 2 comments

Comments

@acolombier
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently, only a subset of URI are supported, while some other like genre or medialistconfig aren't, which preventing deserializing data coming from certain endpoint like rootlist

Describe the solution you'd like

SpotifyId could be refactored to aligned better with the underlying core concept; this way, SpotifyId and SpotifyItemType would become SpotifyUri, and the enum would define sub part, such as SpotifyID (Spotify ID in the above doc), but not exclusively, like it is the case with the current structure.

Describe alternatives you've considered

Alternatively, I have currently extended the existing Struct/Enum relation, which allows supporting these additional URI type in a non-breaking way, but this leads to inconsistency, which is likely to grow as more URI type are added

Additional context

N/A

@acolombier acolombier changed the title Support additionnal SpotifyUri Support additionnal SpotifyUri types Mar 19, 2024
@acolombier
Copy link
Contributor Author

Happy to help implementing the later if that is of interest

@roderickvd
Copy link
Member

Sounds like a good idea. Feel free to open a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants