Skip to content

Commit fbca23d

Browse files
committed
Updated the default parameter checking for debug and release builds
For debug builds, we'll do full parameter checking and assert if that fails. For release builds, we'll do fast parameter checking and return if that fails.
1 parent ca926e9 commit fbca23d

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

src/SDL_internal.h

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,19 +322,27 @@ typedef enum {
322322
SDL_INVALID_PARAM_CHECKS_FULL,
323323
} SDL_InvalidParamChecks;
324324

325+
#ifndef SDL_INVALID_PARAM_CHECKS_DEFAULT
325326
#ifdef SDL_DEBUG_BUILD
326327
#define SDL_INVALID_PARAM_CHECKS_DEFAULT SDL_INVALID_PARAM_CHECKS_FULL
327328
#else
328-
#define SDL_INVALID_PARAM_CHECKS_DEFAULT SDL_INVALID_PARAM_CHECKS_DISABLED
329+
#define SDL_INVALID_PARAM_CHECKS_DEFAULT SDL_INVALID_PARAM_CHECKS_FAST
329330
#endif
331+
#endif // !SDL_INVALID_PARAM_CHECKS_DEFAULT
330332

331333
typedef enum {
332334
SDL_INVALID_PARAM_ACTION_RETURN,
333335
SDL_INVALID_PARAM_ACTION_ASSERT,
334336
SDL_INVALID_PARAM_ACTION_ABORT,
335337
} SDL_InvalidParamAction;
336338

339+
#ifndef SDL_INVALID_PARAM_ACTION_DEFAULT
340+
#ifdef SDL_DEBUG_BUILD
337341
#define SDL_INVALID_PARAM_ACTION_DEFAULT SDL_INVALID_PARAM_ACTION_ASSERT
342+
#else
343+
#define SDL_INVALID_PARAM_ACTION_DEFAULT SDL_INVALID_PARAM_ACTION_RETURN
344+
#endif
345+
#endif // !SDL_INVALID_PARAM_ACTION_DEFAULT
338346

339347
extern SDL_InvalidParamChecks SDL_invalid_param_checks;
340348
extern SDL_InvalidParamAction SDL_invalid_param_action;

0 commit comments

Comments
 (0)