Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a frame at the end showing the result for the GIF generation #18

Open
l3d00m opened this issue Jun 13, 2020 · 2 comments
Open

Add a frame at the end showing the result for the GIF generation #18

l3d00m opened this issue Jun 13, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@l3d00m
Copy link

l3d00m commented Jun 13, 2020

The GIF endpoint could also contain a field for the game result. In PGN it's usually included in the Header or at the very end, like "{ Black wins on time. } 0-1"

This could then be shown on a final frame, as the viewer currently can only guess the result, especially if won on time. This would also remove the need to show the last frame longer manually.

In case the field in the endpoint is not set, the GIF can just be generated like it currently is.

@niklasf niklasf added the enhancement New feature or request label Jun 13, 2020
@niklasf
Copy link
Member

niklasf commented Oct 23, 2020

Apparently Twitter shortens the last frame, which makes it hard to see the final position. Adding another frame would work around that, too.

@niklasf
Copy link
Member

niklasf commented Feb 23, 2021

Relevant: 8461b96.

cymruu added a commit to cymruu/lila-gif that referenced this issue Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants