LPD-24670 Avoid mutating item by hoisting setItemComponentPropsTransformer to the parent component. This assumes it makes no sense to manage <ClayList.Item> props directly

Author: dsanz

modules/apps/frontend-data-set/frontend-data-set-admin-web/src/main/resources/META-INF/resources/item/selector/FDSAdminItemSelector.tsx

@@ -35,9 +35,15 @@ const views = [
 				!item.dataSetToDataSetListSections.length
 			) {
 
-				// we need to avoid item mutation
+				return {
+					...props, // we need to avoid item mutation
+					item: {
+						...item,
+						symbol: 'warning',
+						tooltip: 'perico'
+					}
+				}
 
-				item.symbol = 'warning';
 			}
 
 			return props;

modules/apps/frontend-data-set/frontend-data-set-web/src/main/resources/META-INF/resources/views/list/List.tsx

@@ -78,10 +78,6 @@ const ListItem = forwardRef<HTMLLIElement, any>(
 			selectionType,
 		} = useContext(FrontendDataSetContext);
 
-		const [viewsContext] = useContext(ViewsContext);
-
-		const activeView: IView = viewsContext.activeView;
-
 		const {description, image, sticker, symbol, title, titleRenderer} =
 			schema;
 
@@ -103,7 +99,6 @@ const ListItem = forwardRef<HTMLLIElement, any>(
 		return (
 			<ClayList.Item
 				{...props}
-				{...(activeView.setItemComponentProps?.({item, props}) ?? {})}
 				ref={ref}
 			>
 				{!selectable ? (
@@ -212,14 +207,23 @@ const ListItemOptionalDropTarget = ({
 }) => {
 	const {className, dropRef} = useFDSDrop({item});
 
+	const [viewsContext] = useContext(ViewsContext);
+
+	const activeView: IView = viewsContext.activeView;
+
+	const props = {
+		className,
+		item,
+		items,
+		onItemSelectionChange,
+		ref:dropRef,
+		schema,
+	};
+
 	return (
 		<ListItem
-			className={className}
-			item={item}
-			items={items}
-			onItemSelectionChange={onItemSelectionChange}
-			ref={dropRef}
-			schema={schema}
+			{...props}
+			{...(activeView.setItemComponentProps?.({item, props}) ?? {})}
 		/>
 	);
 };