Skip to content

Commit 88be248

Browse files
authored
Merge pull request #213 from fortunatomaldonado/LPD-34946
LPD-34946 Check if values are empty and delete styles when not used
2 parents 6dd0fb9 + 1c0304c commit 88be248

23 files changed

+173
-157
lines changed

ckeditor/ckeditor.js

+132-132
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/kama/editor.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/kama/editor_ie.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/kama/editor_ie7.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/kama/editor_ie8.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/kama/editor_iequirks.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/moono-lexicon/editor.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/moono-lexicon/editor_gecko.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/moono-lexicon/editor_ie.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/moono-lexicon/editor_ie8.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/moono-lexicon/editor_iequirks.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/moono-lisa/editor.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/moono-lisa/editor_gecko.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/moono-lisa/editor_ie.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/moono-lisa/editor_ie8.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/moono-lisa/editor_iequirks.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/moono/editor.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/moono/editor_gecko.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/moono/editor_ie.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/moono/editor_ie7.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/moono/editor_ie8.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ckeditor/skins/moono/editor_iequirks.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

plugins/imagespacingbox/plugin.js

+20-4
Original file line numberDiff line numberDiff line change
@@ -57,18 +57,26 @@
5757

5858
var hspace = widget.data.hspace
5959
? widget.data.hspace
60-
: 0;
60+
: '';
6161

6262
var imageElement =
6363
widget.parts.image;
6464

65-
if (imageElement) {
65+
if (imageElement && hspace !== '') {
6666
imageElement.setStyles({
6767
'margin-left':
6868
hspace + 'px',
6969
'margin-right':
7070
hspace + 'px',
7171
});
72+
} else {
73+
imageElement.removeStyle(
74+
'margin-left'
75+
);
76+
77+
imageElement.removeStyle(
78+
'margin-right'
79+
);
7280
}
7381
},
7482
id: 'hspace',
@@ -127,17 +135,25 @@
127135

128136
var vspace = widget.data.vspace
129137
? widget.data.vspace
130-
: 0;
138+
: '';
131139

132140
var imageElement =
133141
widget.parts.image;
134142

135-
if (imageElement) {
143+
if (imageElement && vspace !== '') {
136144
imageElement.setStyles({
137145
'margin-bottom':
138146
vspace + 'px',
139147
'margin-top': vspace + 'px',
140148
});
149+
} else {
150+
imageElement.removeStyle(
151+
'margin-bottom'
152+
);
153+
154+
imageElement.removeStyle(
155+
'margin-top'
156+
);
141157
}
142158
},
143159
id: 'vspace',

0 commit comments

Comments
 (0)