Skip to content

Commit 896bb76

Browse files
committed
IDE-5114 let installer support jdk 17
1 parent 632c406 commit 896bb76

File tree

2 files changed

+24
-37
lines changed

2 files changed

+24
-37
lines changed

build/installers/liferay-workspace-with-devstudio/liferay-workspace-with-devstudio.xml

+15-15
Original file line numberDiff line numberDiff line change
@@ -95,21 +95,6 @@
9595
<isTrue value="${clitools}"/>
9696
</conditionRuleList>
9797
</if>
98-
<if>
99-
<actionList>
100-
<setInstallerVariable name="extraArgumentForJdk17" value=" --add-opens java.prefs/java.util.prefs=ALL-UNNAMED"/>
101-
</actionList>
102-
<ruleList>
103-
<compareValues>
104-
<logic>equals</logic>
105-
<value1>${java_version}</value1>
106-
<value2>17</value2>
107-
</compareValues>
108-
</ruleList>
109-
<elseActionList>
110-
<setInstallerVariable name="extraArgumentForJdk17" value=""/>
111-
</elseActionList>
112-
</if>
11398
<if>
11499
<actionList>
115100
<if>
@@ -424,6 +409,21 @@ ${java_executable}
424409
</if>
425410
</elseActionList>
426411
</if>
412+
<if>
413+
<actionList>
414+
<setInstallerVariable name="extraArgumentForJdk17" value="--add-opens java.prefs/java.util.prefs=ALL-UNNAMED"/>
415+
</actionList>
416+
<conditionRuleList>
417+
<compareText>
418+
<logic>contains</logic>
419+
<text>${java_version}</text>
420+
<value>17</value>
421+
</compareText>
422+
</conditionRuleList>
423+
<elseActionList>
424+
<setInstallerVariable name="extraArgumentForJdk17" value=""/>
425+
</elseActionList>
426+
</if>
427427
<if>
428428
<actionList>
429429
<include>

build/installers/liferay-workspace/liferay-workspace.xml

+9-22
Original file line numberDiff line numberDiff line change
@@ -240,39 +240,26 @@
240240
</if>
241241
</elseActionList>
242242
</if>
243+
<pathManipulation>
244+
<action>nativeAbsolutize</action>
245+
<path>${java_executable}/..</path>
246+
<variable>java_bin_dir</variable>
247+
</pathManipulation>
243248
<if>
244249
<actionList>
245-
<setInstallerVariable name="extraArgumentForJdk17" value=" --add-opens java.prefs/java.util.prefs=ALL-UNNAMED"/>
250+
<setInstallerVariable name="extraArgumentForJdk17" value="--add-opens java.prefs/java.util.prefs=ALL-UNNAMED"/>
246251
</actionList>
247252
<conditionRuleList>
248253
<compareText>
249-
<logic>equals</logic>
250-
<nocase>1</nocase>
254+
<logic>contains</logic>
251255
<text>${java_version}</text>
252256
<value>17</value>
253257
</compareText>
254258
</conditionRuleList>
255259
<elseActionList>
256-
<if>
257-
<actionList>
258-
<setInstallerVariable name="extraArgumentForJdk17" value=""/>
259-
</actionList>
260-
<conditionRuleList>
261-
<compareText>
262-
<logic>contains</logic>
263-
<nocase>1</nocase>
264-
<text>${java_version}</text>
265-
<value>17</value>
266-
</compareText>
267-
</conditionRuleList>
268-
</if>
260+
<setInstallerVariable name="extraArgumentForJdk17" value=""/>
269261
</elseActionList>
270-
</if>
271-
<pathManipulation>
272-
<action>nativeAbsolutize</action>
273-
<path>${java_executable}/..</path>
274-
<variable>java_bin_dir</variable>
275-
</pathManipulation>
262+
</if>
276263
<include>
277264
<file>../components/run-java-jpm-win.xml</file>
278265
</include>

0 commit comments

Comments
 (0)