master lpd 84733#465
Open
kyle-miho wants to merge 3 commits into
Open
Conversation
kyle-miho
commented
Jun 1, 2026
| <Method name="getVersion" /> | ||
| </Match> | ||
|
|
||
| <!-- |
Member
Author
There was a problem hiding this comment.
We need to add exclusions even though we made a fix for these methods because Spotbugs expects the fix for Path traversal to be FilenameUtils.getName(xxx) which will strip any subdirectory paths. So we still need to make the proper fix as well as adding the exclusions.
kyle-miho
force-pushed
the
master-lpd-84733
branch
from
68460b4 to
59934ad
Compare
kyle-miho
commented
Jun 1, 2026
| /** | ||
| * @author Kyle Miho | ||
| */ | ||
| public class ZipUtilTests extends BaseTests { |
Member
Author
There was a problem hiding this comment.
Made with help from Claude, I reviewed and cleaned this up, tested and works. Adjusted the variable names a bit, but I'm unsure with names such as tempDir even though I think the name makes a lot of sense, it doesnt perfectly fit the xxxxClassName format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-84733
Also manually tested in Liferay IDE