last minute cleanup

Author: Reecepbcups

scripts/test_node.sh

@@ -2,7 +2,7 @@
 # Run this script to quickly install, setup, and run the current chain without docker.
 #
 # Example:
-# POA_ADMIN_ADDRESS=manifest1hj5fveer5cjtn4wd6wstzugjfdxzl0xp8ws9ct CHAIN_ID="local-1" HOME_DIR="~/.manifest" TIMEOUT_COMMIT="2500ms" CLEAN=true sh scripts/test_node.sh
+# POA_ADMIN_ADDRESS=manifest1hj5fveer5cjtn4wd6wstzugjfdxzl0xp8ws9ct CHAIN_ID="local-1" HOME_DIR="~/.manifest" TIMEOUT_COMMIT="500ms" CLEAN=true sh scripts/test_node.sh
 # CHAIN_ID="local-2" HOME_DIR="~/.manifest2" CLEAN=true RPC=36657 REST=2317 PROFF=6061 P2P=36656 GRPC=8090 GRPC_WEB=8091 ROSETTA=8081 TIMEOUT_COMMIT="500ms" sh scripts/test_node.sh
 #
 # To use unoptomized wasm files up to ~5mb, add: MAX_WASM_SIZE=5000000
@@ -66,18 +66,13 @@ from_scratch () {
   # mint
   update_test_genesis '.app_state["mint"]["params"]["mint_denom"]="umfx"' # not used
   update_test_genesis '.app_state["mint"]["params"]["blocks_per_year"]="6311520"'
-  # update_test_genesis '.app_state["mint"]["minter"]["inflation"]="0.000000000000000000"' # does not matter
-  # update_test_genesis '.app_state["mint"]["params"]["inflation_rate_change"]="1.000000000000000000"'
-  # update_test_genesis '.app_state["mint"]["params"]["inflation_min"]="0.000000000000000000"'
-  # update_test_genesis '.app_state["mint"]["params"]["inflation_max"]="1.000000000000000000"'
-  # crisis
-  # update_test_genesis '.app_state["crisis"]["constant_fee"]={"denom": "umfx","amount": "1000"}'
 
   # Custom Modules
 
   # TokenFactory
   update_test_genesis '.app_state["tokenfactory"]["params"]["denom_creation_fee"]=[]'
   update_test_genesis '.app_state["tokenfactory"]["params"]["denom_creation_gas_consume"]=2000000'
+
   # manifest
   update_test_genesis '.app_state["manifest"]["params"]["inflation"]["mint_denom"]="umfx"'
   update_test_genesis '.app_state["manifest"]["params"]["inflation"]["yearly_amount"]="500000000000"' # in micro format (1MFX = 10**6)
@@ -132,4 +127,4 @@ sed -i 's/address = ":8080"/address = "0.0.0.0:'$ROSETTA'"/g' $HOME_DIR/config/a
 sed -i 's/timeout_commit = "5s"/timeout_commit = "'$TIMEOUT_COMMIT'"/g' $HOME_DIR/config/config.toml
 
 # Start the node
-BINARY start --pruning=nothing  --minimum-gas-prices=0umfx --rpc.laddr="tcp://0.0.0.0:$RPC" --log_level=debug
+BINARY start --pruning=nothing  --minimum-gas-prices=0umfx --rpc.laddr="tcp://0.0.0.0:$RPC"

x/manifest/client/cli/tx.go

@@ -45,7 +45,8 @@ func MsgUpdateParams() *cobra.Command {
 			if err != nil {
 				return err
 			}
-			senderAddress := cliCtx.GetFromAddress()
+
+			sender := cliCtx.GetFromAddress()
 
 			sh, err := fromStrToStakeholders(args[0])
 			if err != nil {
@@ -63,7 +64,7 @@ func MsgUpdateParams() *cobra.Command {
 			}
 
 			msg := &types.MsgUpdateParams{
-				Authority: senderAddress.String(),
+				Authority: sender.String(),
 				Params:    types.NewParams(sh, isInflationEnabled, coin.Amount.Uint64(), coin.Denom),
 			}
 
@@ -90,15 +91,16 @@ func MsgDeployStakeholderPayout() *cobra.Command {
 			if err != nil {
 				return err
 			}
-			senderAddress := cliCtx.GetFromAddress()
+
+			authority := cliCtx.GetFromAddress()
 
 			coin, err := sdk.ParseCoinNormalized(args[0])
 			if err != nil {
 				return err
 			}
 
 			msg := &types.MsgPayoutStakeholders{
-				Authority: senderAddress.String(),
+				Authority: authority.String(),
 				Payout:    coin,
 			}
 

x/manifest/keeper/keeper.go

@@ -114,6 +114,7 @@ func (k Keeper) CalculateShareHolderTokenPayout(ctx context.Context, c sdk.Coin)
 
 	// iter each stakeholder, get their percent of the total 100%, and then split up their amount of coin cost
 	for _, s := range sh {
+		s := s
 		pct := sdkmath.NewInt(int64(s.Percentage)).ToLegacyDec().QuoInt64(types.MaxPercentShare)
 		coinAmt := pct.MulInt(c.Amount).RoundInt()
 
@@ -128,6 +129,10 @@ func (k Keeper) CalculateShareHolderTokenPayout(ctx context.Context, c sdk.Coin)
 	return pairs
 }
 
+// PayoutStakeholders mints coins and sends them to the stakeholders.
+// This is called from the endblocker, so panics should never happen.
+// If it does, something is very wrong w/ the SDK. Any logic specific to auto minting
+// should be kept out of this to properly handle and return nil instead.
 func (k Keeper) PayoutStakeholders(ctx context.Context, c sdk.Coin) error {
 	pairs := k.CalculateShareHolderTokenPayout(ctx, c)
 
@@ -166,9 +171,12 @@ func (k Keeper) BlockRewardsProvision(ctx context.Context, denom string) sdk.Coi
 	amtPerYear := params.Inflation.YearlyAmount
 	blocksPerYear := mkParams.BlocksPerYear
 
-	div := amtPerYear / blocksPerYear
+	if blocksPerYear < 10 {
+		k.logger.Error("x/mint blocks per year param is too low", "blocks", blocksPerYear)
+		return sdk.NewCoin(denom, sdkmath.ZeroInt())
+	}
 
-	k.logger.Debug("amtPerYear", "amt", amtPerYear, "blocksPerYear", blocksPerYear, "div", div)
+	div := amtPerYear / blocksPerYear
 
 	// return the amount of coins to be minted per block
 	return sdk.NewCoin(denom, sdkmath.NewIntFromUint64(div))

x/manifest/module.go

@@ -103,6 +103,8 @@ func (a AppModuleBasic) RegisterGRPCGatewayRoutes(clientCtx client.Context, mux
 }
 
 // AutoCLIOptions implements the autocli.HasAutoCLIConfig interface.
+//
+//nolint:stylecheck
 func (a AppModule) AutoCLIOptions() *autocliv1.ModuleOptions {
 	return &autocliv1.ModuleOptions{
 		Query: &autocliv1.ServiceCommandDescriptor{