Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove panic usage in keeper methods #49

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

fmorency
Copy link
Collaborator

This PR removes the panic usage in keeper methods. This should fix the remaining CodeQL warnings.

Code hygiene following cosmos/cosmos-sdk#18636, cosmos/cosmos-sdk#16212 and cosmos/cosmos-sdk#12985

@fmorency fmorency added the enhancement New feature or request label Apr 25, 2024
@fmorency fmorency self-assigned this Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 59.69%. Comparing base (6a7913e) to head (e77fe05).

Files Patch % Lines
x/manifest/keeper/keeper.go 50.00% 6 Missing and 2 partials ⚠️
x/manifest/abci.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   59.86%   59.69%   -0.17%     
==========================================
  Files          34       34              
  Lines        2145     2151       +6     
==========================================
  Hits         1284     1284              
- Misses        802      805       +3     
- Partials       59       62       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmorency fmorency merged commit ee953c5 into liftedinit:main Apr 26, 2024
13 of 14 checks passed
@fmorency fmorency deleted the error-not-panic branch April 26, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants