Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test vectors for sub-sat output sorting #927

Open
TheBlueMatt opened this issue May 24, 2021 · 1 comment
Open

Update test vectors for sub-sat output sorting #927

TheBlueMatt opened this issue May 24, 2021 · 1 comment
Assignees
@jkczyz
Milestone
0.2

Comments

@TheBlueMatt
Copy link
Collaborator

See lightning/bolts#876 we already do it right but should add the new test vectors.
@jkczyz jkczyz self-assigned this May 24, 2021
@jkczyz
Copy link
Contributor

jkczyz commented May 25, 2021

Hmm... so I'm getting an off-by-one for the to-local output when making the change. The problem seems similar to lightning/bolts#539 (comment). Namely, the outputs plus fees total one less than expected.

@TheBlueMatt TheBlueMatt added this to the 0.1.1 milestone Aug 12, 2021
@ConorOkus ConorOkus moved this to Todo in LDK Roadmap Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkczyz jkczyz

Labels
None yet
Projects
LDK Roadmap
Status: Todo
Milestone
0.2
Development

No branches or pull requests
2 participants
@TheBlueMatt @jkczyz