-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require X-Accept-Authenticate: LN-invoice header #12
Comments
Interesting proposal, I think this makes a lot of sense. Would you suggest this to be a header that MUST be implemented (using the RFC meaning of must here) by a software that wants to be LSAT compliant or more of an extension that CAN be used? Meaning, on the server side, can you be certain the client doesn't support LSAT if the header isn't present or could the header just not be implemented there? |
Good question. If a server sends invoice regardless it probably only hurts itself or UX. (Although I believe sending both the invoice and some fallback page works?) If the header is not present it should mean "doesn't support or doesn't wish to use it". |
We've been working on a middleware library for LSAT's Gin: https://github.com/getAlby/gin-lsat, and we are also wondering if a client should initiate the LSAT flow by sending a certain Another advantage for the client would be that in the case that the files are large (eg. video), this would prevent unneeded downloading of the free content if you are actually after the paid content. |
I've discussed this with @bumi before and I think the conclusion was that the |
@guggero that's exactly why I wrote |
Accept-Authenticate sounds good to me, it's open and general. ( - isn't the What would be the proposed value of the |
Interesting, didn't know about 6648. I proposed |
wondering if |
So to recap: the header's name would be |
How/Where should we add this in the spec description? |
I'd add a new section to https://github.com/lightninglabs/LSAT/blob/master/protocol-specification.md, maybe call it "Client support signaling" or something like that. |
Relevant to this document perhaps issue perhaps: lightning/blips#26 |
I was randomly thinking about payment protocol over HTTP and realized it'd be nicer to require that the client sends
X-Accept-Authenticate: LN-invoice header
(could be standardized to not requireX-
in the future) This allows the server to know upfront that the client actually supports LN.Advantages:
Disadvantages:
X-Supports-LN: example.com/*, *.example.com/*
, the browser could then offer the user to enable LN for that website.The text was updated successfully, but these errors were encountered: