Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accomodate grpc v1.40.0 402 response code / error formatting changes #18

Open
dstadulis opened this issue May 25, 2023 · 0 comments
Open

Comments

@dstadulis
Copy link

Dysfunction

As mentioned in lightninglabs/pool#451 and other PRs google.golang.org/grpc v1.40.0 has changed their 402 response code by improving the parsing from the HTTP/2 stack (see grpc/grpc-go#4474). Consequently when the response code is output by gRPC, it's format has changed.

Necessary Remediation

This output change necessitates an update to L402 to continue to be compatible. Short term mitigation is to downgrade to grpc v1.39.0

Scope

Scope of engineering work to fix should be easy

@dstadulis dstadulis changed the title accomodate grpc v1.40.0 formattting changes to handle 402 response code / error properly accomodate grpc v1.40.0 402 response code / error formatting changes May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant