assets swap deposits [4/N]: add deposit kit encapsulating TAP deposit interactions #2316
bhandrasmain.yml
on: pull_request
RPC compilation check
1m 26s
go mod check
9m 30s
build and lint code
2m 27s
run unit tests
15m 12s
Annotations
9 errors
|
build and lint code
Process completed with exit code 2.
|
|
build and lint code:
assets/client.go#L914
unnecessary trailing newline (whitespace)
|
|
build and lint code:
assets/client.go#L906
handleSendEvent - result 1 (error) is always nil (unparam)
|
|
build and lint code:
assets/deposit/kit.go#L143
(*Kit).genTimeoutPathSiblingPreimage - result 1 (*github.com/btcsuite/btcd/chaincfg/chainhash.Hash) is never used (unparam)
|
|
build and lint code:
assets/client.go#L453
ineffectual assignment to err (ineffassign)
|
|
build and lint code:
assets/client.go#L417
S1031: unnecessary nil check around range (gosimple)
|
|
build and lint code:
assets/htlc/swapkit.go#L243
unslice: could simplify taprootAssetRoot[:] to taprootAssetRoot (gocritic)
|
|
build and lint code:
assets/htlc/swapkit.go#L202
unslice: could simplify taprootAssetRoot[:] to taprootAssetRoot (gocritic)
|
|
build and lint code:
assets/client.go#L828
use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
|