Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Extend the RFQ service to handle asset sell (send) initiated lightning payments #818

Closed
ffranr opened this issue Feb 29, 2024 · 0 comments · Fixed by #835
Closed
Assignees
Labels
enhancement New feature or request rfq
Milestone

Comments

@ffranr
Copy link
Contributor

ffranr commented Feb 29, 2024

The current RFQ service implementation supports asset purchase requests, enabling users to acquire tap assets at the end of a Lightning payment chain. This issue seeks to extend the RFQ service to encompass requests for asset sales. This enhancement enables users to settle a Lightning invoice by conducting an asset sale to the next hop in a Lightning payment route, based on mutual agreement.

Based on my assessment, the most straightforward method to accommodate asset sales within the RFQ service involves introducing new message types specifically designed for initiating and accepting asset sale requests. The existing request and accept message types will be designated for asset purchases only.

Upon completing this issue, the RFQ message types will be:

  • SellRequest for initiating a sale,
  • SellAccept for confirming the acceptance of a sale,
  • BuyRequest for initiating a purchase,
  • BuyAccept for confirming the acceptance of a purchase,
  • Reject for declining any of the above requests.

Separate buy and sell request messages provides flexibility for the future, simplicity in naming and documenting fields, and unambiguous types in code.

@ffranr ffranr added enhancement New feature or request rfq labels Feb 29, 2024
@ffranr ffranr self-assigned this Feb 29, 2024
@ffranr ffranr moved this from 🆕 New to 🏗 In progress in Taproot-Assets Project Board Feb 29, 2024
@dstadulis dstadulis added this to the v0.4 milestone Mar 5, 2024
@ffranr ffranr moved this from 🏗 In progress to 👀 In review in Taproot-Assets Project Board Mar 27, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rfq
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants