Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLIP update: RFQ wire messages #859

Closed
1 task done
dstadulis opened this issue Mar 26, 2024 · 4 comments
Closed
1 task done

BLIP update: RFQ wire messages #859

dstadulis opened this issue Mar 26, 2024 · 4 comments
Assignees
Labels
bips enhancement New feature or request
Milestone

Comments

@dstadulis
Copy link
Collaborator

dstadulis commented Mar 26, 2024

TODO

Merged

#845 #683 #792 #778

Cover the RFQ implementations in which some slight updates
@ffranr to enumerate those updates in this issue

@dstadulis dstadulis added enhancement New feature or request bips labels Mar 26, 2024
@dstadulis dstadulis moved this from 🆕 New to 💇‍♂️Needs Shaping in Taproot-Assets Project Board Mar 26, 2024
@ffranr
Copy link
Contributor

ffranr commented Apr 3, 2024

The changes I think we should make to RFQ section of the tap BLIP can be found in these reviews that I've left on the tap BLIP PR:

lightning/blips#29 (review)
lightning/blips#29 (review)
lightning/blips#29 (review)
lightning/blips#29 (review)
lightning/blips#29 (review)
lightning/blips#29 (review)


Summary

I'll create PR(s) for the following RFQ section modifications:

Other lower priority modifications:

  • Add an expiry Unix timestamp to the suggested BTC amount (currently: suggested_rate_tick) included in the request message.
  • Version fields? Or are we just going to bump the message type integer?
  • Add asset group key field to the request message type. This will allow us to setup a quote for any asset from the given asset group.
  • Other small fixes.

@ffranr ffranr moved this from 💇‍♂️Needs Shaping to 🏗 In progress in Taproot-Assets Project Board Apr 4, 2024
@dstadulis dstadulis changed the title Update RFQ BIP to incorporate implimentation details Update RFQ BIP to incorporate implementation details May 15, 2024
@dstadulis dstadulis added this to the v0.4.1 milestone Jul 16, 2024
@ffranr
Copy link
Contributor

ffranr commented Jul 24, 2024

Corresponding PR: Roasbeef/blips#4

@dstadulis
Copy link
Collaborator Author

Almost ready
can be pulled out of draft soon
@ffranr will apply some small changes

@ffranr ffranr changed the title Update RFQ BIP to incorporate implementation details Update RFQ wire messages in tap BLIP Sep 11, 2024
@ffranr
Copy link
Contributor

ffranr commented Sep 11, 2024

In this issue, we are implementing the following changes:

  • Versioning support.
  • Introduction of fixed-point types for the in-asset and out-asset BTC fields.
  • Addition of a transfer_type field to the quote request message.
  • Expiry will now be represented as a Unix timestamp in seconds.
  • Removal of any references to rate ticks; we are now using fixed points.
  • The max_amount field in the quote request message is replaced by max_transferable_in_asset.

These changes follow the guidelines outlined in docs/rfq-and-decimal-display.md as detailed here: PR #1059.

@ffranr ffranr changed the title Update RFQ wire messages in tap BLIP BLIP update: RFQ wire messages Sep 11, 2024
@ffranr ffranr closed this as completed Oct 4, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bips enhancement New feature or request
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants