Skip to content

Commit fa3b46c

Browse files
max-svistunovtisnik
authored andcommitted
Replace Optional[] with X | None, update test mocks
1 parent 541c20d commit fa3b46c

2 files changed

Lines changed: 8 additions & 14 deletions

File tree

src/utils/responses.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,8 @@ async def prepare_tools(
159159

160160

161161
def _build_provider_data_headers(
162-
tools: Optional[list[dict[str, Any]]],
163-
) -> Optional[dict[str, str]]:
162+
tools: list[dict[str, Any]] | None,
163+
) -> dict[str, str] | None:
164164
"""Build extra HTTP headers containing MCP provider data for Llama Stack.
165165
166166
Extracts per-server auth headers from MCP tool definitions and encodes

tests/unit/utils/test_responses.py

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -983,12 +983,9 @@ async def test_prepare_responses_params_includes_mcp_provider_data_headers(
983983
},
984984
]
985985

986-
mocker.patch("utils.responses.configuration", mocker.Mock())
987-
mocker.patch(
988-
"utils.responses.select_model_and_provider_id",
989-
return_value=("provider1/model1", "model1", "provider1"),
990-
)
991-
mocker.patch("utils.responses.evaluate_model_hints", return_value=(None, None))
986+
mock_config = mocker.Mock()
987+
mock_config.inference = None
988+
mocker.patch("utils.responses.configuration", mock_config)
992989
mocker.patch("utils.responses.get_system_prompt", return_value="System prompt")
993990
mocker.patch(
994991
"utils.responses.prepare_tools", return_value=mcp_tools_with_headers
@@ -1034,12 +1031,9 @@ async def test_prepare_responses_params_no_extra_headers_without_mcp_tools(
10341031

10351032
query_request = QueryRequest(query="test") # pyright: ignore[reportCallIssue]
10361033

1037-
mocker.patch("utils.responses.configuration", mocker.Mock())
1038-
mocker.patch(
1039-
"utils.responses.select_model_and_provider_id",
1040-
return_value=("provider1/model1", "model1", "provider1"),
1041-
)
1042-
mocker.patch("utils.responses.evaluate_model_hints", return_value=(None, None))
1034+
mock_config = mocker.Mock()
1035+
mock_config.inference = None
1036+
mocker.patch("utils.responses.configuration", mock_config)
10431037
mocker.patch("utils.responses.get_system_prompt", return_value="System prompt")
10441038
mocker.patch("utils.responses.prepare_tools", return_value=None)
10451039
mocker.patch("utils.responses.prepare_input", return_value="test")

0 commit comments

Comments
 (0)