diff --git a/src/app/endpoints/health.py b/src/app/endpoints/health.py index 7a8058d79..6e73037b3 100644 --- a/src/app/endpoints/health.py +++ b/src/app/endpoints/health.py @@ -75,7 +75,7 @@ async def get_providers_health_statuses() -> list[ProviderHealthStatus]: providers = await client.providers.list() logger.debug("Found %d providers", len(providers)) - health_results = [ + return [ ProviderHealthStatus( provider_id=provider.provider_id, status=str(provider.health.get("status", "unknown")), @@ -83,7 +83,6 @@ async def get_providers_health_statuses() -> list[ProviderHealthStatus]: ) for provider in providers ] - return health_results except APIConnectionError as e: logger.error("Failed to check providers health: %s", e) diff --git a/src/app/endpoints/models.py b/src/app/endpoints/models.py index a2f519292..348cf954b 100644 --- a/src/app/endpoints/models.py +++ b/src/app/endpoints/models.py @@ -49,7 +49,7 @@ def parse_llama_stack_model(model: Any) -> dict[str, Any]: if k not in ("provider_id", "provider_resource_id", "model_type") } - legacy_model = { + return { "identifier": getattr(model, "id", ""), "metadata": metadata, "api_model_type": model_type, @@ -58,7 +58,6 @@ def parse_llama_stack_model(model: Any) -> dict[str, Any]: "provider_resource_id": str(custom_metadata.get("provider_resource_id", "")), "model_type": model_type, } - return legacy_model models_responses: dict[int | str, dict[str, Any]] = { diff --git a/src/authorization/resolvers.py b/src/authorization/resolvers.py index 359064d4b..3ce553c0c 100644 --- a/src/authorization/resolvers.py +++ b/src/authorization/resolvers.py @@ -148,8 +148,7 @@ def _get_claims(auth: AuthTuple) -> dict[str, Any]: # No claims for guests return {} - jwt_claims = unsafe_get_claims(token) - return jwt_claims + return unsafe_get_claims(token) @staticmethod def _evaluate_operator( diff --git a/src/models/requests.py b/src/models/requests.py index 4027e3772..c091c6e14 100644 --- a/src/models/requests.py +++ b/src/models/requests.py @@ -503,8 +503,7 @@ def validate_categories( if len(value) == 0: return None # Convert empty list to None for consistency - unique_categories = list(dict.fromkeys(value)) # don't lose ordering - return unique_categories + return list(dict.fromkeys(value)) # don't lose ordering @model_validator(mode="after") def check_feedback_provided(self) -> Self: diff --git a/src/utils/responses.py b/src/utils/responses.py index bdced0f71..16c1927be 100644 --- a/src/utils/responses.py +++ b/src/utils/responses.py @@ -997,8 +997,7 @@ async def select_model_for_responses( and user_conversation.last_used_model and user_conversation.last_used_provider ): - model_id = f"{user_conversation.last_used_provider}/{user_conversation.last_used_model}" - return model_id + return f"{user_conversation.last_used_provider}/{user_conversation.last_used_model}" # 2. Select default model from configuration if configuration.inference is not None: diff --git a/src/utils/tool_formatter.py b/src/utils/tool_formatter.py index 8b200ba1d..bde4741be 100644 --- a/src/utils/tool_formatter.py +++ b/src/utils/tool_formatter.py @@ -36,7 +36,7 @@ def format_tool_response(tool_dict: dict[str, Any]) -> dict[str, Any]: description = clean_description # Extract only the required fields - formatted_tool = { + return { "identifier": tool_dict.get("identifier", ""), "description": description, "parameters": tool_dict.get("parameters", []), @@ -46,8 +46,6 @@ def format_tool_response(tool_dict: dict[str, Any]) -> dict[str, Any]: "type": tool_dict.get("type", ""), } - return formatted_tool - def extract_clean_description(description: str) -> str: """ diff --git a/tests/benchmarks/data_generators.py b/tests/benchmarks/data_generators.py index e39f1d6e7..672f09cba 100644 --- a/tests/benchmarks/data_generators.py +++ b/tests/benchmarks/data_generators.py @@ -155,5 +155,4 @@ def generate_topic_summary() -> str: ], ] - summary = " ".join([random.choice(yap) for yap in yaps]) + "." - return summary + return " ".join([random.choice(yap) for yap in yaps]) + "." diff --git a/tests/e2e/utils/utils.py b/tests/e2e/utils/utils.py index 6b73a0e1f..629b58d70 100644 --- a/tests/e2e/utils/utils.py +++ b/tests/e2e/utils/utils.py @@ -287,5 +287,4 @@ def replace_placeholders(context: Context, text: str) -> str: """ result = text.replace("{MODEL}", context.default_model) result = result.replace("{PROVIDER}", context.default_provider) - result = result.replace("{VECTOR_STORE_ID}", context.faiss_vector_store_id) - return result + return result.replace("{VECTOR_STORE_ID}", context.faiss_vector_store_id) diff --git a/tests/unit/app/endpoints/test_query.py b/tests/unit/app/endpoints/test_query.py index 044fb5bf2..32bc5b83d 100644 --- a/tests/unit/app/endpoints/test_query.py +++ b/tests/unit/app/endpoints/test_query.py @@ -42,8 +42,7 @@ def create_dummy_request() -> Request: request (fastapi.Request): A Request constructed with a bare HTTP scope (type "http") for use in tests. """ - req = Request(scope={"type": "http", "headers": []}) - return req + return Request(scope={"type": "http", "headers": []}) @pytest.fixture(name="setup_configuration") diff --git a/tests/unit/utils/test_responses.py b/tests/unit/utils/test_responses.py index 54ae158aa..37e53fed8 100644 --- a/tests/unit/utils/test_responses.py +++ b/tests/unit/utils/test_responses.py @@ -98,8 +98,7 @@ def make_output_item( Returns: MockOutputItem: Mock object with type, role, and content attributes """ - mock_item = MockOutputItem(item_type=item_type, role=role, content=content) - return mock_item + return MockOutputItem(item_type=item_type, role=role, content=content) def make_content_part(