Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightstep appears to be using pure python thrift code #89

Open
rowillia opened this issue Jan 14, 2020 · 3 comments
Open

Lightstep appears to be using pure python thrift code #89

rowillia opened this issue Jan 14, 2020 · 3 comments
Assignees
@codeboten

Comments

@rowillia
Copy link

I believe the issue is that https://github.com/lightstep/lightstep-tracer-python/blob/master/lightstep/crouton/ttypes.py was generated with 0.9.2, but lightstep now requires 0.10.0. Accessing the accelerated module appears to have changed since 0.10.0 (apache/thrift#844). I recommend you re-generate the thrift code with a newer version of the Thrift compiler.
@codeboten
Copy link
Contributor

Thanks for reporting the issue @rowillia! I'll take a look

@codeboten codeboten self-assigned this Jan 14, 2020
rowillia pushed a commit to rowillia/lightstep-tracer-python that referenced this issue Jan 14, 2020
Use TBinaryProtocolAccelerated when serializing reports.
d843781 
We're currently seeing our services spend a large amount of time inside of the lightstep sdk
serializing reports when they instrument themselves with tracing.  This is in large part due to
the fact that lightstep is using the pure python implemenation of Thrift.

Fixes lightstep#89
@rowillia rowillia mentioned this issue Jan 14, 2020
Closed
@codeboten
Copy link
Contributor

Bumped the version of the thrift compiler with this change #92

@rowillia
Copy link
Author

@codeboten I think you also need #90 to have native mode take over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use TBinaryProtocolAccelerated when serializing reports. rowillia/lightstep-tracer-python
2 participants
@codeboten @rowillia