Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightStep::ScopeManager interface differs from OpenTracing::ScopeManager #101

Open
mkasberg opened this issue Jul 19, 2022 · 0 comments
Open

Comments

@mkasberg
Copy link

In OpenTracing::ScopeManager, the span parameter is a required arg, not a keyword arg.

def activate(span, finish_on_close: true)

https://github.com/opentracing/opentracing-ruby/blob/01304d46b6d8322e23bb2962189c0cd14065c886/lib/opentracing/scope_manager.rb#L21

However, in LightStep::ScopeManager, the span parameter is a keyword arg.

def activate(span:, finish_on_close: true)

This makes LightStep::ScopeManager incompatible with the interface defined in OpenTracing::ScopeManager. For example, this error is thrown if you call activate as defined in the OpenTracing interface.

wrong number of arguments (given 1, expected 0; required keyword: span)

@mkasberg mkasberg changed the title Lightstep::ScopeManager interface differs from OpenTracing::ScopeManager LightStep::ScopeManager interface differs from OpenTracing::ScopeManager Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant