Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding flat option to EAN13 format not working when define the value option in the HTML element #138

Open
asoneji opened this issue Mar 31, 2017 · 3 comments
Open

Adding flat option to EAN13 format not working when define the value option in the HTML element #138

asoneji opened this issue Mar 31, 2017 · 3 comments

Comments

@asoneji
Copy link

asoneji commented Mar 31, 2017

Adding flat option to EAN13 format not working when define the value option in the HTML element.

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <title></title>
</head>
<body>
<br />Barcode1:
<svg id="barcode1"></svg>
<br /><br />Barcode2:
<svg class="barcode" jsbarcode-format="EAN13" jsbarcode-flat=true jsbarcode-value="012345678902"></svg>
<br /><br />Barcode3:
<svg class="barcode" jsbarcode-format="EAN13" flat=true jsbarcode-value="012345678903"></svg>
<br /><br />Barcode4:
<svg class="barcode" jsbarcode-format="EAN13" jsbarcode-flat="true" jsbarcode-value="012345678904"></svg>
</body>
<script src="JsBarcode.all.js"> </script>
<script>
  JsBarcode("#barcode1", "012345678901", {
    format: "ean13",
    flat: true
  });
  JsBarcode(".barcode").init();
</script>
</html>

screen shot 2017-03-31 at 4 31 51 pm
@lindell
Copy link
Owner

lindell commented Apr 3, 2017

I will fix this.

Currently I have to manually add the property to work for HTML rendering which seems not to be done for EAN13´s flat option.

This will be fixed with #107. But I want to wait for some other backwards compatibility breaking change to merge this in (and increase the version to 4). But I might do this earlier than previously thought.

@asoneji
Copy link
Author

asoneji commented Apr 3, 2017

Thanks!

asoneji pushed a commit to asoneji/npos that referenced this issue Apr 3, 2017
- temp fix for barcode flat lindell/JsBarcode#138
556384b 
- added barcode flat to svg
@zorgoz
Copy link

zorgoz commented Sep 2, 2019

Any change on this?

@zorgoz zorgoz mentioned this issue Sep 2, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lindell @zorgoz @asoneji