Skip to content

Latest commit

 

History

History
168 lines (102 loc) · 6.12 KB

cran-comments.md

File metadata and controls

168 lines (102 loc) · 6.12 KB
Raw

mcp 0.3.4

Notes for the reviewer

  • This fixes NOTES about arguments with missing documentation.

R CMD check results

There were no ERRORs or WARNINGs except the usual artificial ones (see "Expected NOTEs and ERRORs" in the bottom of this file).

Test environments

Github Actions: oldrel, release, and devel on Ubuntu. Github Actions: release on MacOS and Windows.

Downstream dependencies

We checked 1 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

  • We saw 0 new problems
  • We failed to check 0 packages

mcp 0.3.3

Notes for the reviewer

  • This is a bug fix release, mostly for compatibility with breaking changes in dependencies, including ggplot 3.4.0 as you kindly notified in a GitHub issue.

R CMD check results

There were no ERRORs or WARNINGs except the usual artificial ones (see "Expected NOTEs and ERRORs" in the bottom of this file).

Test environments

Github Actions: oldrel, release, and devel on Ubuntu. Github Actions: release on MacOS and Windows.

Downstream dependencies

mcp has no downstream dependencies.

mcp 0.3.2

Notes for the reviewer

  • This release makes the test suite compatible with dplyr 1.0.8. There are no user-facing changes.

R CMD check results

There were no ERRORs or WARNINGs except the usual artificial ones (see "Expected NOTEs and ERRORs").

Test environments

rhub oldrel, release, and devel on macOS, Linux, and Windows

Downstream dependencies

mcp has no downstream dependencies.

Resubmission

This is a resubmission. I have corrected the invalid URLs in the README.

mcp 0.3.1

Notes for the reviewer

  • This is a patch release that fixes breaking changes in dependencies.

  • Please see unpreventable "Expected NOTEs and ERRORs" in the bottom of this file.

R CMD check results

There were no ERRORs or WARNINGs.

The DESCRIPTION elicits a few NOTEs on rhub:

  • An incorrect NOTE about misspelled words (correctly spelled family names).
  • The DOIs work, but Rhub is unable to verify them.

Test environments

rhub oldrel, release, and devel on macOS, Linux, and Windows

Downstream dependencies

mcp has no downstream dependencies.

mcp 0.3.0

Notes for the reviewer

  • This release adds support for dplyr 1.0+ and other newer packages which caused the prior mcp to be taken down from CRAN. Sorry it took so long.

  • rhub currently have issues with utf8 resulting in the error Error in loadNamespace(name) : there is no package called 'utf8'. See r-hub/rhub#374. This has nothing to do with mcp.

  • Please see unpreventable "Expected NOTEs and ERRORs" in the bottom of this file.

Test environments

  • local Windows 10, R 3.6.1
  • Ubuntu 18.04 (on travis-ci): devel and release
  • Mac OS X 10.13.6 (on travis-ci): release
  • Windows Server 2008 R2 SP1 (on rhub): devel
  • win-builder: devel and release

R CMD check results

There were no ERRORs, WARNINGs, or NOTEs.

Downstream dependencies

mcp has no downstream dependencies.

Resubmission 3

  • Deleted call to options(mc.cores = 3).
  • See the section "Expected NOTEs and ERRORs" below for anticipated ERRORs and NOTEs.

Resubmission 2

  • Fixed grammatical error in DESCRIPTION.
  • mcp now spawns at most 2 cores on CRAN.

Resubmission

This is a resubmission. I believe I have solved all the points raised in the initial review. All tests pass. In this version I have:

  • Added single quotes around 'mcp' in DESCRIPTION.
  • Added literature to DESCRIPTION with the theoretical foundation for the computations done in mcp.
  • mcp no longer copies code from other packages so no attribution/ctb is required.
  • print() and cat() now only reside within print() and summary() functions.
  • All functions have a \value specified now. This has led me to do many other improvements in the documentation too.
  • All examples run now. Some have been enclosed in \donttest() to reduce runtimes.
  • I have taken the liberty to add a few API-breaking updates to mcp in this resubmission, so that the API is as stable as possible from the initial CRAN release. These are: (1) changed plotting of time-series, (2) the function name to simulate data, and (3) changed the summary() output for simulated data.

mcp 0.2.0

Notes for the reviewer

  • This is the first submission of the mcp package and my first CRAN submission personally. I have done my best to adhere to all standards. Extensive documentation for mcp is available at https://lindeloev.github.io/mcp/.
  • The package patchwork is a dependency which just arrived on CRAN a few days ago. It seems it has not rolled out to all test servers. Travis and devtools::check_rhub() install it just fine.
  • My email address is long-term. I have had it for 15 years and I co-own the domain.
  • mcp uses the GPL-2 license. The only code copied (verbatim) from other packages is in R/lme4_utils.R, is GPL (>=2), and has been given proper attribution via the @authors Roxygen tag.
  • mcp does not make any external changes (files, options, communication, etc.)

Test environments

  • local Windows 10, R 3.6.1
  • Ubuntu 16.04.6 LTS (on travis-ci): release
  • Ubuntu 16.04.6 LTS (on travis-ci): devel
  • Mac OS X 10.13.3 (on travis-ci): release

R CMD check results

There were no ERRORs or WARNINGs.

Downstream dependencies

This is the first submission so there are no downstream dependencies.

Expected NOTEs and ERRORs

  • INSTALL ERROR or PREPERROR: mcp uses JAGS (an external binary) for sampling through the rjags package. rjags will fail to install without JAGS on the system. This happens when I run devtools::check_win_release(), devtools::check_win_devel() and rhub::check_for_cran(). Github Actions install JAGS prior to installing packages, and all tests pass on Windows, MacOS, and Linux. Binaries for JAGS are here: https://sourceforge.net/projects/mcmc-jags/files/JAGS/4.x/

  • DESCRIPTION NOTE: rhub says that the DESCRIPTION DOIs return a HTTP 403 error (forbidden). But the DOI works just fine, e.g., http://doi.org/10.2307/2986119.

  • DESCRIPTION NOTE: rhub says that "Lindeløv" (my family name) and "Gelfand" (an researcher's family name) are misspelled.