Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidybayes integration #88

Open
mjskay opened this issue Aug 3, 2020 · 0 comments
Open

tidybayes integration #88

mjskay opened this issue Aug 3, 2020 · 0 comments

Comments

@mjskay
Copy link

mjskay commented Aug 3, 2020

Saw the announcement of the new release on Twitter, looks awesome!

I had two questions about tidybayes integration:

  1. I see you're using tidy_samples instead of implementing a generic for tidybayes::tidy_draws... Are there limitations of the tidy_draws interface that motivate this choice or is there a difference in semantics? If there are changes in tidybayes that would make it possible to make the interfaces consistent I'd be open to it.

  2. Any interest in implementing add_fitted_draws/add_predicted_draws/etc? I haven't come up with a good way to make that easy on package developers yet but if there was interest on your part this might be the opportunity to think through how to make that happen. There is also a feature discussion for {posterior} related to generics for these kinds of functions (Adding generics of general Bayesian methods stan-dev/posterior#39) that I will probably be basing future implementations of add_fitted_draws/add_predicted_draws/etc on, having your input there might be helpful too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant