Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerMetrics does not support multiple ports properly #6089

Open
yzfeng2020 opened this issue Feb 10, 2025 · 4 comments · May be fixed by #6116
Open

ServerMetrics does not support multiple ports properly #6089

yzfeng2020 opened this issue Feb 10, 2025 · 4 comments · May be fixed by #6116
Labels
Milestone

Comments

@yzfeng2020
Copy link
Contributor

Currently, ServerMetrics is not designed to be per-port, which can lead to metric conflicts in the following scenarios:

  • A single server instance serving on multiple ports.
  • Multiple server instances running in the same JVM, each listening on different ports.

Since metrics are aggregated globally without distinguishing ports, this could cause incorrect reporting and make it difficult to track performance or diagnose issues per port.

We could introduce port as a label in ServerMetrics to differentiate metrics per port. This change would allow more granular monitoring and prevent conflicts in multi-port or multi-instance environments.

@ikhoon
Copy link
Contributor

ikhoon commented Feb 11, 2025

We could introduce port as a label in ServerMetrics to differentiate metrics per port.

Good idea.

@ikhoon ikhoon added the defect label Feb 11, 2025
@ikhoon ikhoon added this to the 1.32.0 milestone Feb 11, 2025
@minwoox
Copy link
Contributor

minwoox commented Feb 12, 2025

@yzfeng2020 Do you want to fix this by yourself?

@yzfeng2020
Copy link
Contributor Author

@minwoox hey I won't have capacity for the next two weeks or so, feel free to pick it up if you, or anyone else have time!

@minwoox
Copy link
Contributor

minwoox commented Feb 12, 2025

@yzfeng2020 I will implement this so it can be included in the next release. 😉

@minwoox minwoox linked a pull request Feb 20, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants