Skip to content

Commit 67e392d

Browse files
committed
Update GTK file dialog filter equality comment.
1 parent d6b4538 commit 67e392d

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

druid-shell/src/backend/gtk/dialog.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,12 @@ pub(crate) fn get_file_dialog_path(
5959
if let Some(file_types) = &options.allowed_types {
6060
for f in file_types {
6161
let filter = file_filter(f);
62+
// We need to clone filter, because we may need it again for the default filter.
63+
// It has to be the same FileFilter instance and can't be a new file_filter() call.
6264
dialog.add_filter(filter.clone());
6365

6466
if let Some(default) = &options.default_type {
6567
if default == f {
66-
// Note that we're providing the same FileFilter object to
67-
// add_filter and set_filter, because gtk checks them for
68-
// identity, not structural equality.
6968
dialog.set_filter(&filter);
7069
found_default_filter = true;
7170
}

0 commit comments

Comments
 (0)