Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review API for type improvements #218

Open
madig opened this issue Dec 21, 2021 · 2 comments
Open

Review API for type improvements #218

madig opened this issue Dec 21, 2021 · 2 comments
Milestone
1.0.0

Comments

@madig
Copy link
Collaborator

madig commented Dec 21, 2021

See https://blog.logrocket.com/improving-overconstrained-rust-library-apis/, e.g. the "Into the Woods" section for possible improvements to functions taking optional arguments.
@madig madig added this to the 1.0.0 milestone Dec 21, 2021
@cmyr
Copy link
Member

cmyr commented Dec 24, 2021

we do similar things in a few places, like various arguments take impl Into<Arc<T>>, so you can pass either an existing Arc<T> or just a T.

@madig
Copy link
Collaborator Author

madig commented Dec 25, 2021

Ah, yes. I'm thinking GlyphBuilder and the various new functions for anchors, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@madig @cmyr