Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designspaces: handle localization #323

Open
madig opened this issue Sep 4, 2023 · 2 comments
Open

Designspaces: handle localization #323

madig opened this issue Sep 4, 2023 · 2 comments

Comments

@madig
Copy link
Collaborator

madig commented Sep 4, 2023

The spec describes e.g. https://fonttools.readthedocs.io/en/latest/designspaceLib/xml.html#stylename-familyname-stylemapstylename-stylemapfamilyname-elements-localised-names-for-instances to assign localized names. Norad may want to handle that.

@cmyr
Copy link
Member

cmyr commented Sep 12, 2023

Yes we will definitely want to handle this, and I can't really imagine doing it without custom serde impls. I wish that the spec were a bit clearer on expectations here; in particular, is it possible to have only localized names, or should there only be localized names if there is also a default name?

My first thought is to replace the use of Option<String> for this type with an Option<LocalizedString> that is some custom type that wraps some sort of collection..

@madig
Copy link
Collaborator Author

madig commented Sep 12, 2023

My understanding last time is that the normal attribute for e.g. family name is lang "en", unless there's an explicit "en" entry in localized family name, but I haven't thought about it too hard. designspaceLib uses a dict[str, str] for these localized attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants