Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FromStr rather than fn parse #98

Open
waywardmonkeys opened this issue Jul 30, 2024 · 0 comments
Open

Use FromStr rather than fn parse #98

waywardmonkeys opened this issue Jul 30, 2024 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@waywardmonkeys
Copy link
Contributor

In fontique there are some methods parse which could instead use FromStr and be able to use the str::parse function as detailed here: https://doc.rust-lang.org/std/primitive.str.html#method.parse

These methods are:

  • GenericFamily::parse()
  • Stretch::parse()
  • Style::parse()
  • Weight::parse()

This was suggested by @DJMcNab in #97.
@waywardmonkeys waywardmonkeys added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@waywardmonkeys