Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more tests into piet-common #415

Open
cmyr opened this issue Mar 10, 2021 · 0 comments
Open

Move more tests into piet-common #415

cmyr opened this issue Mar 10, 2021 · 0 comments
Labels
maintenance cleanup and refactoring

Comments

@cmyr
Copy link
Member

cmyr commented Mar 10, 2021

There are a bunch of tests duplicated across various backends, and it makes sense to move these into piet-common.

The only tests that really need to be backend-specific are tests that rely on platform fonts or behaviour related to platform fonts, like things for hit-testing?

There are also a few tests that were removed from piet-common because of cairo toy-text; these include the missing_font_is_missing test.

@cmyr cmyr added the maintenance cleanup and refactoring label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance cleanup and refactoring
Projects
None yet
Development

No branches or pull requests

1 participant