Refine regex in `function wordToFiles( word )`

[hugolpz]

Need to define issue better. It seems to work as intended within the top right popup. Search of accueil returns video of accueil (lieu). Maybe was just caching issue with the API.

Current intersection from (1) clicked-word via window.select() and (2) list of videos recordings is handled by function wordToFiles( word ).

This function is too restrictive and must be more inclusive.

May need edit 3 background-script.js sections :

• function wordToFiles
  • .hasOwnProperty usage may be to review
• var sparqlSignVideosQuery , to test in https://lingualibre.org/bigdata/#query
• function getAllRecords( signLanguage )

Additional cases to handle

Selected word	Existing word string	Existing filename string
coucou	coucou (accrocher le regard)	File:LL-Q33302_(fsl)-Hugo_en_résidence-coucou_(accrocher_le_regard).webm
accueil	accueil (lieu) accueil	File:LL-Q33302_(fsl)-Hugo_en_résidence-accueil_(lieu).webm File:LL-Q33302_(fsl)-Taliba31-accueil.webm

Screenshot

As of Monday noon , it failed. (Recording on Saturday noon...)

Recorded video file exists, but SignIt don't find it !

In the 4th image, an other video (File:LL-Q33302_(fsl)-Taliba31-accueil.webm) is shown but only it. A second one (File:LL-Q33302_(fsl)-Hugo_en_résidence-accueil_(lieu).webm) should be available.

[EDIT]

As of Monday evening , it works. (Recording on Saturday noon...)

Participative listing

Other cases are observed to not work. You can add them in the table above to ease the work of the developer.

[shashankiitbhu]

@hugolpz Hi, is anyone working on this? If not , Can I work on this issue?

[pushkar707]

I have solved this to some extent.

I have put a check to find if there's a single word from the complete selection whose record is available.

If there is, we return a record for the first word whose record is there.

if this is okay, I will make a PR.

[hugolpz]

@pushkar707 , this is not okay, this is great Q___Q

Your PR is welcome yes ! 🌻
Let's test it.

[pushkar707]

Thanks a lot :), I have already made PR #57.

I was not able to link it to the issue. Please check it.

[pushkar707]

Do you know how we can proceed with this issue? Should we display a carousel of all the available words, if multiple words are selected?

[hugolpz]

@pushkar707 I never though this far to be honest. I took over this extension in a lower point it took be some time to bring it up to current status.

Convention

What I can confirm is we have videos names with the convention of word (clarification), such as :

• hi (hello).webm
• hi (surprise).webm
• hi (scream).webm

Note: our videos are French Sign Language for now due to lack of contributors from other countries but the principle is true.

What we want

Given text such as:

hi how are you ?

When double clicking hi, the 3 videos cited above should be available on the video gallery.

I'm not sure the split by space is the best, but it implements a split and collection of words from the split, so it's interesting. 👍🏼 We can build upon your code, split by (, and keep parts[0] if we decide to.

[kabir-afk]

@pushkar707 I never though this far to be honest. I took over this extension in a lower point it took be some time to bring it up to current status.

Convention

What I can confirm is we have videos names with the convention of word (clarification), such as :

• hi (hello).webm
• hi (surprise).webm
• hi (scream).webm

Note: our videos are French Sign Language for now due to lack of contributors from other countries but the principle is true.

What we want

Given text such as:

hi how are you ?

When double clicking hi, the 3 videos cited above should be available on the video gallery.

I'm not sure the split by space is the best, but it implements a split and collection of words from the split, so it's interesting. 👍🏼 We can build upon your code, split by (, and keep parts[0] if we decide to.

You are right, while approach taken by @pushkar707 is ideal , it needs a lil bit of refactoring as it dies down when punctuation marks come in between. For example it'll work for croissant dépassant. But if something like croissant, dépassant, i.e., a croissant with a comma , it doesn't work as there is no croissant, inside records . I'll try to refactor it. Also this will only work in FF for now since records aren't populated properly in sw.js for chrome

[hugolpz]

@kabir-afk , regex improvement discussions come here.