Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xliff): initial implementation of xliff format #1676

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(xliff): initial implementation of xliff format #1676

wants to merge 1 commit into from

Conversation

timofei-iatsenko
Copy link
Collaborator

Description

Related: #1675

Todo List:

  • Serialization Lingui Catalog to the XLIFF format
  • Parsing XLIFF format to the Lingui Catalog
    • Preserve attributes on the trans-unit such as state="final"
    • Preserve children which might be added to trans-unit by TMS
    • Ideally when lingui updates xliff files it should touch only related fields and left the rest of the document as-is, this will ensure no custom properties or elements are lost during merging.
  • Documentation update

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented May 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 11:13am

@github-actions
Copy link

github-actions bot commented May 26, 2023 •
edited
Loading

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 1.44 KB (0%)
./packages/detect-locale/dist/index.mjs 721 B (0%)
./packages/react/dist/index.mjs 1.59 KB (0%)
./packages/remote-loader/dist/index.mjs 7.24 KB (0%)

@codecov
Copy link

codecov bot commented May 26, 2023 •
edited
Loading

Codecov Report

Patch coverage: 88.88% and project coverage change: +0.11 🎉

Comparison is base (894c877) 75.72% compared to head (6e28cf9) 75.83%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1676      +/-   ##
==========================================
+ Coverage   75.72%   75.83%   +0.11%     
==========================================
  Files          79       80       +1     
  Lines        2039     2057      +18     
  Branches      524      527       +3     
==========================================
+ Hits         1544     1560      +16     
- Misses        379      381       +2     
  Partials      116      116
Impacted Files Coverage Δ
packages/format-xliff/src/xliff.ts 88.88% <88.88%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrii-bodnar andrii-bodnar linked an issue Jun 7, 2023 that may be closed by this pull request
[Feature Request] XLIFF format support #1675
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] XLIFF format support
1 participant
@timofei-iatsenko