Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depth.launch.py on humble fails #94

Open
gitisacatsname opened this issue Oct 12, 2023 · 0 comments
Open

depth.launch.py on humble fails #94

gitisacatsname opened this issue Oct 12, 2023 · 0 comments

Comments

@gitisacatsname
Copy link

gitisacatsname commented Oct 12, 2023

If e.g. realsense is selected value mapper fails as it is evaluated with realsense value:

to_oakd_vars = {
    "oakd": "OAK-D",
    "oakdlite": "OAK-D-LITE",
    "oakdpro": "OAK-D-PRO"
}

this is evaluated at launch causing it to fail (sensor is realsense):

 launch_arguments={
                'camera_model': to_oakd_vars[LaunchConfiguration('sensor')],  

I would prefer this

IncludeLaunchDescription( PythonLaunchDescriptionSource(PathJoinSubstitution( [FindPackageShare('depthai_examples'), 'launch', 'stereo.launch.py'] )), condition=IfCondition(PythonExpression(['"', LaunchConfiguration('sensor'), '" in "', str(oakd_sensors), '"'])), launch_arguments={ 'camera_model': PythonExpression(["'OAK-D' if 'oakd' in ", LaunchConfiguration('sensor'), " else 'OAK-D-LITE' if 'oakdlite' in ", LaunchConfiguration('sensor'), " else 'OAK-D-PRO' if 'oakdpro' in ", LaunchConfiguration('sensor')," else 'UNKNOWN'"]), }.items() ),

otherwise valuemapper will fail if e.g. realsense is used. this broke launch for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant