Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document usage of IP address printing #130

Open
razvand opened this issue May 4, 2019 · 4 comments
Open

Document usage of IP address printing #130

razvand opened this issue May 4, 2019 · 4 comments
Assignees
@Sergiu121
Labels
labs Kernel practical labs

Comments

@razvand
Copy link

razvand commented May 4, 2019

Add a section in the Networking lab on using specific printing formats for IP address, such as %pI4. Add examples.
@razvand razvand added the labs Kernel practical labs label May 4, 2019
@Sergiu121
Copy link

Sergiu121 commented May 4, 2019 •
edited
Loading

There is one in the first exercise, but there was a problem in the initial lab commit. I fixed the problem in #129.

@razvand
Copy link
Author

razvand commented May 4, 2019

There is one in the first exercise, but there was a problem in the initial lab commit. I fixed the problem in #129.

My proposal was to have actual examples and explanation as part of the lab text, not the exercises.

@Sergiu121
Copy link

Would it be ok to move the explanation to a netfilter subsection?

@razvand
Copy link
Author

razvand commented May 6, 2019

Would it be ok to move the explanation to a netfilter subsection?

I think it's OK. I would recommend to add a separate section at the end of the lab titled "Printing network addresses". With 2 paragraphs and some small code snippets as usage samples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sergiu121 Sergiu121

Labels
labs Kernel practical labs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@razvand @Sergiu121