test: add unit tests for export and file parsers by pengfeixx · Pull Request #566 · linuxdeepin/deepin-log-viewer

pengfeixx · 2026-10-27T11:25:04Z

Part 8/8 of the deepin-log-viewer unit-test coverage series (single-commit PR; all 8 PRs touch disjoint file sets and are mutually independent).

Files in this PR (8 files, +1445/-26 lines)

tests/src/ut_logsegementexportthread.cpp (new)
tests/dbusproxy/ut_userlogaccess.cpp (new)
tests/src/ut_logfileparser.cpp
tests/src/ut_logexportthread.cpp
tests/src/ut_wtmpparse.cpp
tests/src/ut_logoocfileparsethread.cpp
tests/src/ut_logapplication.cpp
tests/src/ut_logsettings.cpp

Notes

Test-only change: no production source code is modified.
New test files live in tests/src/ / tests/dbusproxy/ / tests/ut_logviewerplugin/, globbed automatically by tests/CMakeLists.txt (re-run cmake after pulling).
Each file was compiled and executed individually (GTest + lcov) in its generating task; whole-branch build verification recommended in CI.
Series goal: function coverage toward 100% (baseline: 690 passing cases, 68.2% function / 58.5% line coverage).

Summary by Sourcery

Increase unit-test coverage for log export and file-parsing functionality without modifying production code.

Enhancements:

Expand unit-test coverage across log export, file parsing, user log access, application notification, settings, and wtmp parsing paths.

Tests:

Add comprehensive tests for segment and log export behavior, parser branches, DBus-backed file access, compressed logs, streaming reads, and wtmp edge cases.

Chores:

Improve test isolation with temporary files, stubs, and environment-independent handling for external commands and authentication checks.

sourcery-ai · 2026-10-27T11:25:10Z

Sorry @pengfeixx, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 55 minutes by commenting @sourcery-ai review. Upgrade to get a review now.

sourcery-ai · 2026-10-27T11:25:19Z

Reviewer's Guide

This test-only PR completes the eighth coverage batch by adding a new UserLogAccess and log-segment export suite and extending parser, export, application, wtmp, OOC-thread, and settings tests with mocked external dependencies, temporary filesystem fixtures, and success, failure, lifecycle, and dispatch branch coverage.

File-Level Changes

Change	Details	Files
Adds comprehensive unit coverage for log segment export behavior across text, HTML, DOC, XLS, lifecycle, stopping, and formatting paths.	Introduces tests for parameter setup, document/spreadsheet initialization, export success and failure paths, escaping, cleanup, and run-state branches. Stubs DocxFactory and utility operations to isolate export logic and avoid external side effects.	`tests/src/ut_logsegementexportthread.cpp`
Expands log export thread tests to cover append state, ZIP/core-dump export, translation, escaping, and audit/auth output modes.	Exercises ZIP setup, running, early-stop, core-dump filtering, and mocked process/DBus interactions. Covers text, HTML, DOC, and XLS audit/auth run modes with mocked document generation dependencies.	`tests/src/ut_logexportthread.cpp`
Adds broad parser dispatch and log-source coverage using thread-pool, DBus, application-configuration, and authentication-list stubs.	Tests parser entry points for dpkg, Xorg, normal, KWin, boot, kernel, DNF, dmesg, audit, auth, coredump, and default types. Covers application parsing with single, multiple, and missing submodules.	`tests/src/ut_logfileparser.cpp`
Adds UserLogAccess tests for file reading, metadata, ranged access, streaming, caching, compression, extraction, indexing, singleton behavior, and destruction.	Uses temporary files/directories and conditional gzip tooling to cover normal, invalid, directory, compressed, cache-hit, forward, reverse, and failure paths. Validates private helper behavior for extraction-directory creation, cleanup, decompression, and line-index generation.	`tests/dbusproxy/ut_userlogaccess.cpp`
Improves application notification tests so forwarding behavior executes against a real LogCollectorMain instance.	Stubs timing and parser dependencies, initializes the main-window member for applicable parameterized cases, and verifies notifications without fatal failures. Adds deferred cleanup for created Qt objects.	`tests/src/ut_logapplication.cpp`
Expands wtmp parser tests for valid and invalid descriptors, forward/backward reads, time formatting, list operations, and record branches.	Resets global file state through failed opens to exercise error paths. Adds initialized record data and explicit coverage for missing list elements and BOOT_TIME handling.	`tests/src/ut_wtmpparse.cpp`
Adds lifecycle and guarded-execution coverage for the OOC file parser thread.	Stubs authentication to make doWork deterministic in headless environments. Exercises run and repeated stop-processing behavior.	`tests/src/ut_logoocfileparsethread.cpp`
Adds singleton and audit-map loading tests for log settings.	Verifies repeated instance access returns the same object. Invokes audit-map loading for coverage.	`tests/src/ut_logsettings.cpp`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

github-actions · 2026-10-27T11:25:58Z

Warning

[Debian检查]

检测到敏感词export变动

详情

    {
    "export": {
        "tests/src/ut_logexportthread.cpp": {
            "b": [
                "// ---- stubs for exportToZip / run(ZipCoredump) / run(AUDIT/AUTH) coverage ----",
                "    return \"/tmp/ut_logexport_zip\";",
                "bool stub_zip_exportLog(const QString &outDir, const QString &in, bool isFile)",
                "    exportThread->enableAppendExport(true);",
                "    EXPECT_EQ(exportThread->m_appendExport, true);",
                "    exportThread->enableAppendExport(false);",
                "    EXPECT_EQ(exportThread->m_appendExport, false);",
                "    exportThread->enableAppendExport();",
                "    EXPECT_EQ(exportThread->m_appendExport, true);",
                "TEST_F(LogExportthread_UT, exportToZipPublic_UT)",
                "    exportThread->exportToZipPublic(\"test.zip\", coredumpList, labels);",
                "    EXPECT_EQ(exportThread->m_fileName, QString(\"test.zip\"));",
                "    EXPECT_EQ(exportThread->m_coredumplist.size(), 1);",
                "    EXPECT_EQ(exportThread->m_labels.size(), 2);",
                "    EXPECT_EQ(exportThread->m_runMode, LogExportThread::ZipCoredump);",
                "    EXPECT_EQ(exportThread->m_canRunning, true);",
                "    exportThread->initMap();",
                "    EXPECT_EQ(exportThread->m_levelStrMap.size(), 8);",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Emergency\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Alert\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Critical\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Error\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Warning\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Notice\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Info\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Debug\"));",
                "    exportThread->initMap();",
                "    QString result = exportThread->strTranslate(\"Emergency\");",
                "    QString unknown = exportThread->strTranslate(\"NonExistentLevel\");",
                "    exportThread->htmlEscapeCovert(html);",
                "TEST_F(LogExportthread_UT, exportToZip_UT)",
                "    stub.set(ADDR(DLDBusHandler, exportLog), stub_zip_exportLog);",
                "    exportThread->m_canRunning = true;",
                "    bool res1 = exportThread->exportToZip(\"test_empty.zip\", emptyList);",
                "    exportThread->m_canRunning = true;",
                "    bool res2 = exportThread->exportToZip(\"test_core.zip\", coreList);",
                "    exportThread->m_canRunning = false;",
                "    bool res3 = exportThread->exportToZip(\"test_stop.zip\", coreList);",
                "    stub.set(ADDR(DLDBusHandler, exportLog), stub_zip_exportLog);",
                "    exportThread->m_coredumplist = coreList;",
                "    exportThread->m_fileName = \"test_run.zip\";",
                "    exportThread->m_runMode = LogExportThread::ZipCoredump;",
                "    exportThread->m_canRunning = true;",
                "    exportThread->run();",
                "    EXPECT_NE(exportThread, nullptr);",
                "    exportThread->m_alist = auditList;",
                "    exportThread->m_authlist = authList;",
                "    exportThread->m_fileName = \"test_audit\";",
                "    exportThread->m_labels = QStringList() << \"test\";",
                "    exportThread->m_canRunning = false;",
                "    exportThread->m_runMode = LogExportThread::TxtAUDIT;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::TxtAUTH;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::HtmlAUDIT;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::HtmlAUTH;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::DocAUDIT;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::DocAUTH;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::XlsAUDIT;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::XlsAUTH;",
                "    exportThread->run();",
                "    EXPECT_NE(exportThread, nullptr);"
            ]
        },
        "tests/src/ut_logsegementexportthread.cpp": {
            "b": [
                "#include \"logsegementexportthread.h\"",
                "// exportTxt: KERN + Kwin branches",
                "    QString fname = \"/tmp/ut_seg_export_txt.txt\";",
                "    EXPECT_TRUE(m_thread->exportTxt());",
                "    EXPECT_TRUE(m_thread->exportTxt());",
                "    EXPECT_TRUE(m_thread->exportTxt());",
                "// exportTxt: file open failure path",
                "    EXPECT_FALSE(m_thread->exportTxt());",
                "// exportHtml: KERN + Kwin branches",
                "    QString fname = \"/tmp/ut_seg_export_html.html\";",
                "    EXPECT_TRUE(m_thread->exportHtml());",
                "    EXPECT_TRUE(m_thread->exportHtml());",
                "// exportHtml: open failure path",
                "    EXPECT_FALSE(m_thread->exportHtml());",
                "// exportToDoc: KERN + Kwin branches",
                "    m_thread->setParameter(\"/tmp/ut_seg_export_doc.doc\", data, labels, KERN);",
                "    EXPECT_TRUE(m_thread->exportToDoc());",
                "    EXPECT_TRUE(m_thread->exportToDoc());",
                "    EXPECT_FALSE(m_thread->exportToDoc());",
                "// exportToXls: KERN + Kwin branches + null guard",
                "    m_thread->setParameter(\"/tmp/ut_seg_export_xls.xls\", data, labels, KERN);",
                "    EXPECT_TRUE(m_thread->exportToXls());",
                "    EXPECT_TRUE(m_thread->exportToXls());",
                "    removeTempFile(\"/tmp/ut_seg_export_xls.xls\");",
                "    EXPECT_FALSE(m_thread->exportToXls());"
            ]
        }
    }
}

github-actions · 2026-10-27T11:30:25Z

Warning

[Debian检查]

检测到敏感词export变动

详情

    {
    "export": {
        "tests/src/ut_logexportthread.cpp": {
            "b": [
                "// ---- stubs for exportToZip / run(ZipCoredump) / run(AUDIT/AUTH) coverage ----",
                "    return \"/tmp/ut_logexport_zip\";",
                "bool stub_zip_exportLog(const QString &outDir, const QString &in, bool isFile)",
                "    exportThread->enableAppendExport(true);",
                "    EXPECT_EQ(exportThread->m_appendExport, true);",
                "    exportThread->enableAppendExport(false);",
                "    EXPECT_EQ(exportThread->m_appendExport, false);",
                "    exportThread->enableAppendExport();",
                "    EXPECT_EQ(exportThread->m_appendExport, true);",
                "TEST_F(LogExportthread_UT, exportToZipPublic_UT)",
                "    exportThread->exportToZipPublic(\"test.zip\", coredumpList, labels);",
                "    EXPECT_EQ(exportThread->m_fileName, QString(\"test.zip\"));",
                "    EXPECT_EQ(exportThread->m_coredumplist.size(), 1);",
                "    EXPECT_EQ(exportThread->m_labels.size(), 2);",
                "    EXPECT_EQ(exportThread->m_runMode, LogExportThread::ZipCoredump);",
                "    EXPECT_EQ(exportThread->m_canRunning, true);",
                "    exportThread->initMap();",
                "    EXPECT_EQ(exportThread->m_levelStrMap.size(), 8);",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Emergency\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Alert\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Critical\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Error\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Warning\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Notice\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Info\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Debug\"));",
                "    exportThread->initMap();",
                "    QString result = exportThread->strTranslate(\"Emergency\");",
                "    QString unknown = exportThread->strTranslate(\"NonExistentLevel\");",
                "    exportThread->htmlEscapeCovert(html);",
                "TEST_F(LogExportthread_UT, exportToZip_UT)",
                "    stub.set(ADDR(DLDBusHandler, exportLog), stub_zip_exportLog);",
                "    exportThread->m_canRunning = true;",
                "    bool res1 = exportThread->exportToZip(\"test_empty.zip\", emptyList);",
                "    exportThread->m_canRunning = true;",
                "    bool res2 = exportThread->exportToZip(\"test_core.zip\", coreList);",
                "    exportThread->m_canRunning = false;",
                "    bool res3 = exportThread->exportToZip(\"test_stop.zip\", coreList);",
                "    stub.set(ADDR(DLDBusHandler, exportLog), stub_zip_exportLog);",
                "    exportThread->m_coredumplist = coreList;",
                "    exportThread->m_fileName = \"test_run.zip\";",
                "    exportThread->m_runMode = LogExportThread::ZipCoredump;",
                "    exportThread->m_canRunning = true;",
                "    exportThread->run();",
                "    EXPECT_NE(exportThread, nullptr);",
                "    exportThread->m_alist = auditList;",
                "    exportThread->m_authlist = authList;",
                "    exportThread->m_fileName = \"test_audit\";",
                "    exportThread->m_labels = QStringList() << \"test\";",
                "    exportThread->m_canRunning = false;",
                "    exportThread->m_runMode = LogExportThread::TxtAUDIT;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::TxtAUTH;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::HtmlAUDIT;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::HtmlAUTH;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::DocAUDIT;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::DocAUTH;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::XlsAUDIT;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::XlsAUTH;",
                "    exportThread->run();",
                "    EXPECT_NE(exportThread, nullptr);"
            ]
        },
        "tests/src/ut_logsegementexportthread.cpp": {
            "b": [
                "#include \"logsegementexportthread.h\"",
                "// exportTxt: KERN + Kwin branches",
                "    QString fname = \"/tmp/ut_seg_export_txt.txt\";",
                "    EXPECT_TRUE(m_thread->exportTxt());",
                "    EXPECT_TRUE(m_thread->exportTxt());",
                "    EXPECT_TRUE(m_thread->exportTxt());",
                "// exportTxt: file open failure path",
                "    EXPECT_FALSE(m_thread->exportTxt());",
                "// exportHtml: KERN + Kwin branches",
                "    QString fname = \"/tmp/ut_seg_export_html.html\";",
                "    EXPECT_TRUE(m_thread->exportHtml());",
                "    EXPECT_TRUE(m_thread->exportHtml());",
                "// exportHtml: open failure path",
                "    EXPECT_FALSE(m_thread->exportHtml());",
                "// exportToDoc: KERN + Kwin branches",
                "    m_thread->setParameter(\"/tmp/ut_seg_export_doc.doc\", data, labels, KERN);",
                "    EXPECT_TRUE(m_thread->exportToDoc());",
                "    EXPECT_TRUE(m_thread->exportToDoc());",
                "    EXPECT_FALSE(m_thread->exportToDoc());",
                "// exportToXls: KERN + Kwin branches + null guard",
                "    m_thread->setParameter(\"/tmp/ut_seg_export_xls.xls\", data, labels, KERN);",
                "    EXPECT_TRUE(m_thread->exportToXls());",
                "    EXPECT_TRUE(m_thread->exportToXls());",
                "    removeTempFile(\"/tmp/ut_seg_export_xls.xls\");",
                "    EXPECT_FALSE(m_thread->exportToXls());"
            ]
        }
    }
}

github-actions · 2026-10-27T11:34:45Z

Warning

[Debian检查]

检测到敏感词export变动

详情

    {
    "export": {
        "tests/src/ut_logexportthread.cpp": {
            "b": [
                "// ---- stubs for exportToZip / run(ZipCoredump) / run(AUDIT/AUTH) coverage ----",
                "    return \"/tmp/ut_logexport_zip\";",
                "bool stub_zip_exportLog(const QString &outDir, const QString &in, bool isFile)",
                "    exportThread->enableAppendExport(true);",
                "    EXPECT_EQ(exportThread->m_appendExport, true);",
                "    exportThread->enableAppendExport(false);",
                "    EXPECT_EQ(exportThread->m_appendExport, false);",
                "    exportThread->enableAppendExport();",
                "    EXPECT_EQ(exportThread->m_appendExport, true);",
                "TEST_F(LogExportthread_UT, exportToZipPublic_UT)",
                "    exportThread->exportToZipPublic(\"test.zip\", coredumpList, labels);",
                "    EXPECT_EQ(exportThread->m_fileName, QString(\"test.zip\"));",
                "    EXPECT_EQ(exportThread->m_coredumplist.size(), 1);",
                "    EXPECT_EQ(exportThread->m_labels.size(), 2);",
                "    EXPECT_EQ(exportThread->m_runMode, LogExportThread::ZipCoredump);",
                "    EXPECT_EQ(exportThread->m_canRunning, true);",
                "    exportThread->initMap();",
                "    EXPECT_EQ(exportThread->m_levelStrMap.size(), 8);",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Emergency\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Alert\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Critical\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Error\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Warning\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Notice\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Info\"));",
                "    EXPECT_TRUE(exportThread->m_levelStrMap.contains(\"Debug\"));",
                "    exportThread->initMap();",
                "    QString result = exportThread->strTranslate(\"Emergency\");",
                "    QString unknown = exportThread->strTranslate(\"NonExistentLevel\");",
                "    exportThread->htmlEscapeCovert(html);",
                "TEST_F(LogExportthread_UT, exportToZip_UT)",
                "    stub.set(ADDR(DLDBusHandler, exportLog), stub_zip_exportLog);",
                "    exportThread->m_canRunning = true;",
                "    bool res1 = exportThread->exportToZip(\"test_empty.zip\", emptyList);",
                "    exportThread->m_canRunning = true;",
                "    bool res2 = exportThread->exportToZip(\"test_core.zip\", coreList);",
                "    exportThread->m_canRunning = false;",
                "    bool res3 = exportThread->exportToZip(\"test_stop.zip\", coreList);",
                "    stub.set(ADDR(DLDBusHandler, exportLog), stub_zip_exportLog);",
                "    exportThread->m_coredumplist = coreList;",
                "    exportThread->m_fileName = \"test_run.zip\";",
                "    exportThread->m_runMode = LogExportThread::ZipCoredump;",
                "    exportThread->m_canRunning = true;",
                "    exportThread->run();",
                "    EXPECT_NE(exportThread, nullptr);",
                "    exportThread->m_alist = auditList;",
                "    exportThread->m_authlist = authList;",
                "    exportThread->m_fileName = \"test_audit\";",
                "    exportThread->m_labels = QStringList() << \"test\";",
                "    exportThread->m_canRunning = false;",
                "    exportThread->m_runMode = LogExportThread::TxtAUDIT;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::TxtAUTH;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::HtmlAUDIT;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::HtmlAUTH;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::DocAUDIT;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::DocAUTH;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::XlsAUDIT;",
                "    exportThread->run();",
                "    exportThread->m_runMode = LogExportThread::XlsAUTH;",
                "    exportThread->run();",
                "    EXPECT_NE(exportThread, nullptr);"
            ]
        },
        "tests/src/ut_logsegementexportthread.cpp": {
            "b": [
                "#include \"logsegementexportthread.h\"",
                "// exportTxt: KERN + Kwin branches",
                "    QString fname = \"/tmp/ut_seg_export_txt.txt\";",
                "    EXPECT_TRUE(m_thread->exportTxt());",
                "    EXPECT_TRUE(m_thread->exportTxt());",
                "    EXPECT_TRUE(m_thread->exportTxt());",
                "// exportTxt: file open failure path",
                "    EXPECT_FALSE(m_thread->exportTxt());",
                "// exportHtml: KERN + Kwin branches",
                "    QString fname = \"/tmp/ut_seg_export_html.html\";",
                "    EXPECT_TRUE(m_thread->exportHtml());",
                "    EXPECT_TRUE(m_thread->exportHtml());",
                "// exportHtml: open failure path",
                "    EXPECT_FALSE(m_thread->exportHtml());",
                "// exportToDoc: KERN + Kwin branches",
                "    m_thread->setParameter(\"/tmp/ut_seg_export_doc.doc\", data, labels, KERN);",
                "    EXPECT_TRUE(m_thread->exportToDoc());",
                "    EXPECT_TRUE(m_thread->exportToDoc());",
                "    EXPECT_FALSE(m_thread->exportToDoc());",
                "// exportToXls: KERN + Kwin branches + null guard",
                "    m_thread->setParameter(\"/tmp/ut_seg_export_xls.xls\", data, labels, KERN);",
                "    EXPECT_TRUE(m_thread->exportToXls());",
                "    EXPECT_TRUE(m_thread->exportToXls());",
                "    removeTempFile(\"/tmp/ut_seg_export_xls.xls\");",
                "    EXPECT_FALSE(m_thread->exportToXls());"
            ]
        }
    }
}

1. Add ut_logsegementexportthread.cpp and ut_userlogaccess.cpp 2. Extend logfileparser, logexportthread and wtmpparse tests 3. Extend ooc parse thread, logapplication and logsettings tests Log: No user-facing changes Influence: 1. Run deepin-log-viewer-test with --gtest_filter='*Export*;*Parser*' 2. Verify full suite passes with ASAN_OPTIONS=detect_leaks=0 3. Check lcov function coverage of parsers and export threads test: 新增导出与文件解析单元测试 1. 新增 ut_logsegementexportthread.cpp 与 ut_userlogaccess.cpp 2. 扩展文件解析、导出线程与 wtmp 解析测试 3. 扩展 ooc 解析线程、应用与配置测试 Log: 无用户可见变化 Influence: 1. 运行 deepin-log-viewer-test 过滤 Export/Parser 套件 2. 以 ASAN_OPTIONS=detect_leaks=0 验证全量用例通过 3. 用 lcov 检查解析器与导出线程覆盖率

deepin-bot · 2026-10-27T12:23:52Z

TAG Bot

New tag: 6.5.43
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #567

deepin-ci-robot · 2026-10-27T12:40:22Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, pengfeixx

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot · 2026-10-27T12:47:02Z

deepin pr auto review

🤖 AI 代码审查报告

总体评分： 100 分 (通过阈值: 70分)

📊 总体评价

项目	结果
审查结论	代码审查通过
评分详情	本次提交为 deepin-log-viewer 项目新增单元测试，覆盖 UserLogAccess、LogExportThread、LogFileParser、LogSegementExportThread、LogOOCFileParseThread、LogSettings 及 wtmpparse 等模块的导出与文件解析功能。8 个变更文件均为 tests/ 目录下的测试代码，语法正确、逻辑清晰、注释完整，无安全漏洞，四维度均通过。

🔍 详细分析

1. 语法逻辑 ✅

评价： 语法正确，逻辑清晰 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： []

2. 代码质量 ✅

评价： 代码结构清晰，注释完整 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： ['建议将 ExportRunAuditAuth_UT 中的 8 种 RUN_MODE 拆分为参数化测试（TEST_P），以进一步提升可维护性']

3. 代码性能 ✅

评价： 性能良好，资源使用合理 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： []

4. 代码安全 🔒

评价： 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情：
✅ 未发现安全漏洞

建议： []

💡 改进建议代码示例

// 当前代码质量良好，无需修复。以下为可选的改进建议（参数化测试拆分）：
//
// 将 ExportRunAuditAuth_UT 中的 8 种 RUN_MODE 拆分为参数化测试：
//
// struct AuditAuthParam {
//     LogExportThread::RUN_MODE mode;
//     const char *name;
// };
//
// class LogExportAuditAuthParam : public LogExportthread_UT,
//                                public testing::WithParamInterface<AuditAuthParam> {};
//
// TEST_P(LogExportAuditAuthParam, ExportRunAuditAuth_UT) {
//     // ... stub setup ...
//     exportThread->m_runMode = GetParam().mode;
//     exportThread->run();
//     EXPECT_NE(exportThread, nullptr);
// }
//
// INSTANTIATE_TEST_SUITE_P(AuditAuthModes, LogExportAuditAuthParam,
//     testing::Values(
//         AuditAuthParam{LogExportThread::TxtAUDIT, "TxtAUDIT"},
//         AuditAuthParam{LogExportThread::TxtAUTH, "TxtAUTH"},
//         AuditAuthParam{LogExportThread::HtmlAUDIT, "HtmlAUDIT"},
//         AuditAuthParam{LogExportThread::HtmlAUTH, "HtmlAUTH"},
//         AuditAuthParam{LogExportThread::DocAUDIT, "DocAUDIT"},
//         AuditAuthParam{LogExportThread::DocAUTH, "DocAUTH"},
//         AuditAuthParam{LogExportThread::XlsAUDIT, "XlsAUDIT"},
//         AuditAuthParam{LogExportThread::XlsAUTH, "XlsAUTH"}
//     )
// );

本报告由 AI 代码审查工具自动生成

github-actions Bot requested a review from liujianqiang-niu October 27, 2026 11:25

pengfeixx force-pushed the ut-coverage-batch-8 branch from 6169495 to 8796218 Compare October 27, 2026 11:30

pengfeixx changed the title ~~feat(test): add export and file parser unit tests (batch 8/8)~~ test: add unit tests for export and file parsers Oct 27, 2026

pengfeixx force-pushed the ut-coverage-batch-8 branch from 8796218 to 5fc032d Compare October 27, 2026 11:34

pengfeixx force-pushed the ut-coverage-batch-8 branch from 5fc032d to cfa68fe Compare October 27, 2026 12:09

lzwind approved these changes Oct 27, 2026

View reviewed changes

pengfeixx merged commit 0bd1919 into linuxdeepin:master Oct 27, 2026
14 of 15 checks passed

pengfeixx deleted the ut-coverage-batch-8 branch October 27, 2026 13:02

pengfeixx mentioned this pull request Oct 28, 2026

fix(test): repair UT build and sanitizer failures after coverage series merge #570

Merged

Navigation Menu

Repository navigation

test: add unit tests for export and file parsers - #566

test: add unit tests for export and file parsers#566
pengfeixx merged 1 commit into
linuxdeepin:masterfrom
pengfeixx:ut-coverage-batch-8

pengfeixx commented Oct 27, 2026 •

edited by sourcery-ai Bot

Loading

Uh oh!

sourcery-ai Bot commented Oct 27, 2026

Uh oh!

sourcery-ai Bot commented Oct 27, 2026

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

github-actions Bot commented Oct 27, 2026

Uh oh!

github-actions Bot commented Oct 27, 2026

Uh oh!

github-actions Bot commented Oct 27, 2026

Uh oh!

deepin-bot Bot commented Oct 27, 2026

Uh oh!

deepin-ci-robot commented Oct 27, 2026

Uh oh!

deepin-ci-robot commented Oct 27, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

pengfeixx commented Oct 27, 2026 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Files in this PR (8 files, +1445/-26 lines)

Notes

Summary by Sourcery

Uh oh!

sourcery-ai Bot commented Oct 27, 2026

Uh oh!

sourcery-ai Bot commented Oct 27, 2026

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

github-actions Bot commented Oct 27, 2026

Uh oh!

github-actions Bot commented Oct 27, 2026

Uh oh!

github-actions Bot commented Oct 27, 2026

Uh oh!

deepin-bot Bot commented Oct 27, 2026

Uh oh!

deepin-ci-robot commented Oct 27, 2026

Uh oh!

deepin-ci-robot commented Oct 27, 2026

deepin pr auto review

🤖 AI 代码审查报告

📊 总体评价

🔍 详细分析

1. 语法逻辑 ✅

2. 代码质量 ✅

3. 代码性能 ✅

4. 代码安全 🔒

💡 改进建议代码示例

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pengfeixx commented Oct 27, 2026 •

edited by sourcery-ai Bot

Loading