-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] <title>The data folder and your files are probably accessible from the Internet. #436
Comments
Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid. |
I can confirm that behaviour after update to 29.0.0 What should we do to address that issue? I actually think it might be a false-positive, since I am not able to actually access files from the internet, however some swag config for example could lead to this? Dunno. How to further investigate? |
From some initial investigations I've done on this, it doesn't seem to be something that needs to be fixed within the container but more the permissions set on your |
My permissions do not look too suspicious. But I just found: https://help.nextcloud.com/t/after-upgrade-from-28-to-29-i-have-data-directory-and-your-files-are-probably-accessible-from-the-internet/189882/1 Not yet read that one, but will later |
For me it helped to remove the ip of my server in the local lan from the array of trusted Domains: 'trusted_domains' =>
array (
- 0 => '192.168.178.99',
- 1 => 'my.domain.xyz',
+ #0 => '192.168.178.99',
+ 0 => 'my.domain.xyz',
), |
I have the same issue, and in the trusted domains array only my domain is listed, no ip or local ip. |
I can confirm this workaround works, but it also prevents accessing it locally using the IP address. Here is my config.php (that produces the issue - I want to access it using local ip for the hardwired pc's, so commenting it out isn't ideal)
|
Or you could configure your setup correctly so it's the same address internally and externally. |
So if the reverse proxy goes down for whatever reason, I lose access to it locally as well? This was a working configuration prior to v29 |
You could say that about anything that might go down for whatever reason. Note all these changes are security changes nextcloud are making and are outside of our control. |
Again, the workaround mentionned is not one. |
Could be formatting maybe of the array. Unfortunately I'm not able to reproduce, initially I thought the error was relating to filesystem permissions issues but it seems it's not.
|
workaround :
Same error for me on a fresh install.
|
I'm also affected by this. I had an unused local DNS name and a WAN DNS name in This post explains how this error is detected - the idea seems to be that the PHP variable |
Via discussion in nextcloud/server#45087, I determined that the new Nextcloud API that creates these warnings is quite fragile. In my case, the checker was expecting a By adding There seem to generally be some issues around this new API causing lots of false positives. Not following redirects, not accounting for external auth providers, etc. nextcloud/server#44234 is another example. |
This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
Is there an existing issue for this?
Current Behavior
Greetings,
from version 29.0.0 I get the following error message:
The data folder and your files are probably accessible from the Internet. The .htaccess file does not work. We strongly recommend that you configure the server so that the data folder is no longer accessible or move the folder out of the root of the web server.
This didn't happen with the previous version 28.x.x.
Can you help me
Thank you.
Expected Behavior
No Error!
Steps To Reproduce
Linux Debian - Container Docker-Compose
Environment
CPU architecture
x86-64
Docker creation
Container logs
The text was updated successfully, but these errors were encountered: