Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps-dev): bump rollup from 3.14.0 to 3.21.5 #291

Closed
wants to merge 1 commit into from
Closed

build(deps-dev): bump rollup from 3.14.0 to 3.21.5 #291

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 5, 2023

Bumps rollup from 3.14.0 to 3.21.5.

Release notes

Sourced from rollup's releases.

v3.21.5

3.21.5

2023-05-05

Bug Fixes

  • Keep all consecutive lines at the top of each module that start with a comment (#4975)
  • Ensure that declarations inside switch cases do not use the same scope as the discriminator (#4979)

Pull Requests

v3.21.4

3.21.4

2023-05-03

Bug Fixes

  • Resolve crash when shimming a missing export in an otherwise non-included module when preserving modules (#4971)

Pull Requests

v3.21.3

3.21.3

2023-05-02

Bug Fixes

  • Run process.exit() when Rollup CLI finishes successfully to solve issues on some systems (#4969)

Pull Requests

v3.21.2

3.21.2

2023-04-30

Bug Fixes

... (truncated)

Changelog

Sourced from rollup's changelog.

3.21.5

2023-05-05

Bug Fixes

  • Keep all consecutive lines at the top of each module that start with a comment (#4975)
  • Ensure that declarations inside switch cases do not use the same scope as the discriminator (#4979)

Pull Requests

3.21.4

2023-05-03

Bug Fixes

  • Resolve crash when shimming a missing export in an otherwise non-included module when preserving modules (#4971)

Pull Requests

3.21.3

2023-05-02

Bug Fixes

  • Run process.exit() when Rollup CLI finishes successfully to solve issues on some systems (#4969)

Pull Requests

3.21.2

2023-04-30

Bug Fixes

  • Mark global functions that trigger iterators as impure for now (#4955)

Pull Requests

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
build(deps-dev): bump rollup from 3.14.0 to 3.21.5
5bfa9b0 
Bumps [rollup](https://github.com/rollup/rollup) from 3.14.0 to 3.21.5.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v3.14.0...v3.21.5)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 5, 2023
@dependabot dependabot bot mentioned this pull request May 5, 2023
Closed
@pull-request-quantifier-deprecated
Copy link

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +1 -1
Percentile : 0.8%

Total files changed: 2

Change summary by file extension:
.json : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 9, 2023

Superseded by #294.

@dependabot dependabot bot closed this May 9, 2023
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/rollup-3.21.5 branch May 9, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file Extra Small
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants