Oracle identity column

[luapdb]

I create a table with an ID column
"ADT_ID" NUMBER(19,0) GENERATED BY DEFAULT AS IDENTITY (START with 1 increment by 1),

I then run:

liquibase generateChangeLog

The Change log contains this:

      <column defaultValueComputed="&quot;LIC2_OWNER&quot;.&quot;ISEQ$$_98884&quot;.nextval" name="ADT_ID" remarks="Unique identity number of this audit trail." type="NUMBER(19, 0)">
            <constraints nullable="false"/>

Ideally we should just have metadata - stating identity column and the defaultValueComputed should not be present.

I have looked at the code which generates the SQL from the changeLog and it seems to imply that it should handle the creation of SQL based on the Identity metadata but i have not seen how it extracts this information from the database.

┆Issue is synchronized with this Jira Bug by Unito

[luapdb]

I think this is a problem on the core - but cant figure out how to add this as an issue on liquibase-core

[luapdb]

i looked into the code

in Columnsnapshotgenerator.java - we have this
which is returning isAutoincrement=[NO]

            if (columnMetadataResultSet.containsColumn("IS_AUTOINCREMENT")) {

                String isAutoincrement = (String) columnMetadataResultSet.get("IS_AUTOINCREMENT");
                isAutoincrement = StringUtils.trimToNull(isAutoincrement);
                //System.out.print("isAutoincrement=["+isAutoincrement+"]");

                if (isAutoincrement == null) {

[luapdb]

in JdbcDatabaseSnapShot.java line 357,

we can replace
+ " C.IDENTITY_COLUMN as IS_AUTOINCREMENT, "
for

                    + " 'NO' as IS_AUTOINCREMENT, "

I have not tested but this seems to be the cause