Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: #4

Open
garett-at-liquidlight opened this issue Aug 30, 2023 · 1 comment
Open

Bug: #4

garett-at-liquidlight opened this issue Aug 30, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@garett-at-liquidlight
Copy link

Summary

The DatatableController.php makes the assumption that there will be a column called "deleted", which is true for many tables, but not all. It should instead be looking this up in the TCA in ctrl > enablecolumns > disabled.

Steps to reproduce

Build a datatable controller which selects from, or joins with, a table that does not have a deleted column, such as sys_language

There are a few places this appears in the code:

@garett-at-liquidlight garett-at-liquidlight added the bug Something isn't working label Aug 30, 2023
@mikestreety
Copy link
Contributor

@zaqmughal-ll This is actually half resolved (I think).

In the first example, above where @garett-at-liquidlight has pointed to is

->removeAll()
->add(GeneralUtility::makeInstance(DeletedRestriction::class))

Which is doing exactly what you are doing in the lines below (as per your comment)

I wonder if adding the DeletedRestriction handles tables which don't have a deleted column?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants