Skip to content
This repository has been archived by the owner on Feb 28, 2023. It is now read-only.

Remove constructor.name assertion #264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OiYouYeahYou
Copy link

This breaks current compatibility with the current redis version and
causes an unreasonable expectation of future changes in the future

Fixes: #263

This breaks current compatability with the current redis version and
causes an unreasonable expectation of futrue changes in the future
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #264 (19e7cfb) into master (2d51cee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #264   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          235       229    -6     
=========================================
- Hits           235       229    -6     
Impacted Files Coverage Δ
src/redis.js 100.00% <ø> (ø)
src/serialize.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d51cee...19e7cfb. Read the comment docs.

@anish-joy
Copy link

When are you guys planning to fix this issue, its still breaking while connecting to Redis

@OiYouYeahYou
Copy link
Author

@anish-joy unfortunately I reached out to @RasCarlito just before Christmas last year but haven't heard anything back. At this point I think it's fair to declare this as an abandoned project 😔

#265 has an alternative listed

@anish-joy
Copy link

@OiYouYeahYou Thanks for the update! I really appreciate it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code in documentation fails: Use redis as cache store
2 participants